[AudioEffect] Add a simple bitcrusher effect#109393
Closed
ObaniGemini wants to merge 1 commit intogodotengine:masterfrom
Closed
[AudioEffect] Add a simple bitcrusher effect#109393ObaniGemini wants to merge 1 commit intogodotengine:masterfrom
ObaniGemini wants to merge 1 commit intogodotengine:masterfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
See also: |
Author
|
closing in favor of #68768 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a very cheap to process bitcrusher effect that just lowers the sample rate of the bus.
Why?
Many games use this effect, either to emulate a "retro" feeling or to have some "disturbing/horror" vibe.
Potential enhancements
The max sample rate in the editor is set to 44100Hz, but the user's audioserver sample rate might be different (e.g: 48000Hz). Is there a proper way to change this?
Showcase
music is "Yoni Mayraz - Dybbuk Tse!"
propfight-2025-08-07_15.06.442.mp4
propfight-2025-08-07_15.08.322.mp4
P.S: I used the "amplifier" effect code as a template for making this one, if things aren't necessary and can be removed, I might have missed some of them.