Fix gamepad detection being too picky on Linux#112795
Open
axunes wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am porting a Godot 4.4 game to two linux handhelds, all with face buttons, shoulder buttons, and a d-pad, but only one of those has analog sticks (axes). While one of the handhelds was detected fine, the (otherwise completely identical) one without sticks wasn't providing inputs or being returned by
get_connected_joypads().I changed the line responsible to assume an input device is a gamepad if it has buttons OR sticks as opposed to both of those. At that point the volume buttons were also treated as a gamepad so I added the check from #94776. This may or may not make #93352 obsolete.I made this PR to the best of my ability but I probably still made a mistake somewhere. Sorry.