Update Linux gamepad detection to match SDL.#40591
Merged
Merged
Conversation
Member
|
Let's merge to get this tested in the |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies and eases the constraints on what is considered a gamepad: basically anything with an absolute x- and a y-axis (i.e. not a mouse, which uses relative coordinates) is considered a gamepad. So this will include trackpads and tablets too, but this is probably a desired side-effect.
Could fix #24526, but it will need to be tested, because the issue claims that
test_bit(EV_KEY, evbit)returnsfalsewith a rudder. Also may cause a regression following effectively reverting #37261 too (which added a specific exception that excludes theEV_KEYtest but adds two more axes testsABS_RXandABS_RY). If either is the case then thetest_bit(EV_KEY, evbit)can be dropped too. However, I've kept it, because this is the logic currently used by SDL.