[3.x] Fix export var inferring wrong type of preload#61810
Open
ArshPanesar wants to merge 1 commit intogodotengine:3.xfrom
Open
[3.x] Fix export var inferring wrong type of preload#61810ArshPanesar wants to merge 1 commit intogodotengine:3.xfrom
ArshPanesar wants to merge 1 commit intogodotengine:3.xfrom
Conversation
When assigning 'export var' to preload, the class_name for export property was not bieng set in the _parse_class() function, which caused the export's native type to be mistaken as Object when using _type_from_property() function. This caused a parse error when used in a script. Setting class_name for export property in _parse_class() removed the parse error. Fixes Issue godotengine#61752
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When assigning 'export var' to preload, the class_name for export property was not bieng set in the _parse_class() function, which caused the export's native type to be mistaken as Object when using _type_from_property() function:
This caused a parse error when used in a script.
Setting class_name for export property in _parse_class() removed the parse error.
Fixes #61752