Skip to content

[3.x] Try loading the path specified in a preload(..) method call with the ResourceLoader if the script code completion cache is not yet available #69362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Maran23 wants to merge 1 commit into
base: 3.x
Choose a base branch
from
+2 −0
Open

[3.x] Try loading the path specified in a preload(..) method call with the ResourceLoader if the script code completion cache is not yet available #69362

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions modules/gdscript/gdscript_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -527,6 +527,8 @@ GDScriptParser::Node *GDScriptParser::_parse_expression(Node *p_parent, bool p_s
return nullptr;
} else if (ScriptCodeCompletionCache::get_singleton()) {
res = ScriptCodeCompletionCache::get_singleton()->get_cached_resource(path);
} else {
res = ResourceLoader::load(path);
Comment on lines +530 to +531
Copy link
Copy Markdown
Member

@akien-mga akien-mga Jun 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this code but I feel like the comment in the !validating branch:

//this can be too slow for just validating code

actually explains why this else branch does not do a load, which is expensive.

CC @vnen @adamscott (note: 3.x code)

Copy link
Copy Markdown
Contributor Author

@Maran23 Maran23 Nov 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thought, but better then failing. Since this only affects autoloaded Nodes that uses preload, it seems okay to me

}
}
if (!res.is_valid()) {
Expand Down