[3.x] New SampleRate audio effect#70085
Open
M-O-Marmalade wants to merge 1 commit intogodotengine:3.xfrom
Open
[3.x] New SampleRate audio effect#70085M-O-Marmalade wants to merge 1 commit intogodotengine:3.xfrom
M-O-Marmalade wants to merge 1 commit intogodotengine:3.xfrom
Conversation
M-O-Marmalade
force-pushed
the
audio-effect-sample-rate-3.x
branch
from
1c965b6 to
b9600dc
Compare
akien-mga
changed the title
lawnjelly
reviewed
Feb 28, 2024
|
|
||
| public: | ||
| float rate; | ||
| float mix; |
Member
There was a problem hiding this comment.
Presumably rate and mix should be private?
Member
|
I tested this and it appears to work fine and am happy to approve if the changes above made. I don't know what the feelings are on the proposal / demand .. it does seem we have a number of users making retro games especially on 3.x that could benefit from this kind of chiptune sound. I also don't think this will add much in terms of binary size. |
lawnjelly
reviewed
Feb 28, 2024
| processed_frames = Math::fmod(processed_frames - frames_until_next_sample, 1.0f); | ||
| } | ||
|
|
||
| // output dry/wet signal based on the `mix` control |
Member
There was a problem hiding this comment.
// Output dry/wet signal based on the `mix` control.
We've recently standardized on capitalized / full stops for new comments, so I suppose we should be pedantic. 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #68768 from master branch.
Proposal at godotengine/godot-proposals#5810