[3.x] [X11] Fix initial window hints.#81153
Conversation
akien-mga
changed the title
| #ifdef TOOLS_ENABLED | ||
| String game_path; | ||
| String script; | ||
| String test; | ||
| String export_preset; | ||
| String positional_arg; |
There was a problem hiding this comment.
I'm surprised at this addition, we already had this behavior of figuring out whether running a game, script, or editor based on command line arguments in 3.x. Isn't this duplicating existing logic which was just refactored in 4.x to include the contexts?
There was a problem hiding this comment.
It is duplicating existing logic, but it's in the setup2 and original logic is in the start (too late to set context).
There was a problem hiding this comment.
But it's only used for project manager detection, so can be removed.
There was a problem hiding this comment.
So should we merge as is, or do you want to have a go at simplifying?
There was a problem hiding this comment.
@bruvzg bump as you may have missed akien's comment above.
I'm just looking through PRs for approval and this looks mostly fine, but we were awaiting whether you think this is ok to merge as is?
3 participants
Fixes #81141