Make Ingress Optional

[Vad1mo]

With the Upcoming Kubernetes Gateway API and the wide adoption of different ingress controllers, eg. traefik, ALB etc.

We should not aim to support all the options, but rather keep this chart flexible and lean.

Hence I am proposing to make ingress optional with the flag expose.enabled true/falsedefault is true

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[github-actions]

This PR was closed because it has been stalled for 30 days with no activity. If this PR is still relevant, please re-open a new PR against main.

[acelinkio]

I think this request is incredibly relevant. I no longer use ingress controllers for exposing traffic to my cluster. Any chance this could be reviewed?

[github-actions]

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

[vpechor]

I would say it is still relevant. We also do not use the default ingress object.

[janpipan]

You can disable the ingress object with current chart. If you set the expose.type to clusterIP, the chart will deploy nginx server which will act as a API gateway for harbor services. You can then create HTTPRoute that has a backendRefs set to harbor service which is created when nginx server is deployed. If you would like I can provide you some examples of how we migrated our Harbor Ingress to Gateway API.

[mts-dyt]

@janpipan Do we really need an internal NGINX instance if we want to expose Harbor through another method. This PR really makes sense, more than ever since the announce of NGINX retirement

[NiklasBeierl]

@janpipan

You can disable the ingress object with current chart. If you set the expose.type to clusterIP, the chart will deploy nginx server which will act as a API gateway for harbor services. You can then create HTTPRoute that has a backendRefs set to harbor service which is created when nginx server is deployed. If you would like I can provide you some examples of how we migrated our Harbor Ingress to Gateway API.

It should be noted that expose.type: route will create appropriate HTTPRoutes ever since #2175.
While the MR added a route section to expose, to further configure the gateway, it unfortunately failed to document this additional option for expose.type.

Using expose.type: routes get's rid of the nginx (therefore the extra pass through nginx) and let's your gateway handle the trivial routing tasks that nginx would otherwise perform.

Doc was added in this commit, but that is not yet released.
aefc9ca