Skip to content

Add common annotations for resources created by this chart#2298

Open
dmbuck32 wants to merge 3 commits intogoharbor:mainfrom
dmbuck32:add-common-annotations
Open

Add common annotations for resources created by this chart#2298
dmbuck32 wants to merge 3 commits intogoharbor:mainfrom
dmbuck32:add-common-annotations

Conversation

@dmbuck32
Copy link

@dmbuck32 dmbuck32 commented Jan 21, 2026

What's changing

Adds support for common annotations across all resources deployed by this chart.

Example use case

Useful for adding annotations that are required by kyverno policies on my K8s cluster.

Sample Values.yaml:

commonAnnotations:
  source-code: "<GitHub URL>"
  team: "Internal Team"

Example output:

# Source: harbor/templates/core/core-dpl.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: release-name-harbor-core
  namespace: "release-namespace"
  annotations:
    source-code: "<GitHub URL>"
    team: "Internal Team"
  labels:
    ...

Fixes

Fixes adding annotations to components as part of: #2221

@dmbuck32 dmbuck32 force-pushed the add-common-annotations branch from f388986 to 6fa1377 Compare January 21, 2026 01:35
Signed-off-by: David-Michael Buckman <dmbuck32@gmail.com>
Signed-off-by: David-Michael Buckman <dmbuck32@gmail.com>
Signed-off-by: David-Michael Buckman <dmbuck32@gmail.com>
@dmbuck32 dmbuck32 force-pushed the add-common-annotations branch from 62cc173 to 864f422 Compare January 21, 2026 03:18
@thomasvvugt
Copy link

Would love to see this PR approved as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants