Add common annotations for resources created by this chart#2298
Open
dmbuck32 wants to merge 3 commits intogoharbor:mainfrom
Open
Add common annotations for resources created by this chart#2298dmbuck32 wants to merge 3 commits intogoharbor:mainfrom
dmbuck32 wants to merge 3 commits intogoharbor:mainfrom
Conversation
f388986 to
6fa1377
Compare
Signed-off-by: David-Michael Buckman <dmbuck32@gmail.com>
Signed-off-by: David-Michael Buckman <dmbuck32@gmail.com>
Signed-off-by: David-Michael Buckman <dmbuck32@gmail.com>
62cc173 to
864f422
Compare
|
Would love to see this PR approved as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changing
Adds support for common annotations across all resources deployed by this chart.
Example use case
Useful for adding annotations that are required by kyverno policies on my K8s cluster.
Sample
Values.yaml:Example output:
Fixes
Fixes adding annotations to components as part of: #2221