parametrize gracePeriodTerminationSeconds#2330
Open
tomkukral wants to merge 2 commits intogoharbor:mainfrom
Open
parametrize gracePeriodTerminationSeconds#2330tomkukral wants to merge 2 commits intogoharbor:mainfrom
tomkukral wants to merge 2 commits intogoharbor:mainfrom
Conversation
This option makes sense to be parametrize for huge clusters which may need more time to terminate pods, e.g. during database migrations. Signed-off-by: Tomáš Kukrál <noreply@6shore.net>
This is necessary in cases when migration takes longer then 1h Signed-off-by: Tomáš Kukrál <noreply@6shore.net>
sm-moshi
added a commit
to sm-moshi/harbor-helm
that referenced
this pull request
Mar 16, 2026
Cherry-picked upstream PRs: - goharbor#2310: fix secret drift for ArgoCD (fixes goharbor#2263) - goharbor#2307: default image tag to chart appVersion - goharbor#2314: fix rollingUpdate checks for jobservice/registry - goharbor#2312: fix ArgoCD diff in httproute - goharbor#2317: configurable health probe timeoutSeconds/failureThreshold - goharbor#2330: parametrise gracePeriodTerminationSeconds + core startupProbe Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sm-moshi
added a commit
to sm-moshi/harbor-helm
that referenced
this pull request
Apr 14, 2026
Cherry-picked upstream PRs: - goharbor#2310: fix secret drift for ArgoCD (fixes goharbor#2263) - goharbor#2307: default image tag to chart appVersion - goharbor#2314: fix rollingUpdate checks for jobservice/registry - goharbor#2312: fix ArgoCD diff in httproute - goharbor#2317: configurable health probe timeoutSeconds/failureThreshold - goharbor#2330: parametrise gracePeriodTerminationSeconds + core startupProbe Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sm-moshi
added a commit
to sm-moshi/harbor-helm
that referenced
this pull request
Apr 14, 2026
Cherry-picked upstream PRs: - goharbor#2310: fix secret drift for ArgoCD (fixes goharbor#2263) - goharbor#2307: default image tag to chart appVersion - goharbor#2314: fix rollingUpdate checks for jobservice/registry - goharbor#2312: fix ArgoCD diff in httproute - goharbor#2317: configurable health probe timeoutSeconds/failureThreshold - goharbor#2330: parametrise gracePeriodTerminationSeconds + core startupProbe Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: replace upstream GHA with GHCR OCI release + lint workflows - release.yaml: package and push to oci://ghcr.io/sm-moshi/charts on tag push - lint.yaml: helm lint + template on PRs and sm-moshi/main pushes - Remove upstream-specific workflows (Docker Hub publish, stale issues, integration, unittest) - Add CLAUDE.md with fork maintenance instructions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: replace GitHub Actions with Woodpecker CI pipelines - .woodpecker/lint.yaml: helm lint + template on push/PR - .woodpecker/release.yaml: package, push to ghcr.io/sm-moshi/charts, create GitHub release on tag push - Remove .github/workflows/ (GHA no longer needed) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: use DHI helm 4.1.3 image, pinned by digest Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> build: mark chart as 1.19.0-rc2 to match appVersion v2.15.0-rc2 Chart version should reflect pre-release status while shipping RC images. Will bump to 1.19.0 when Harbor v2.15.0 GA ships. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sm-moshi
added a commit
to sm-moshi/harbor-helm
that referenced
this pull request
Apr 14, 2026
Cherry-picked upstream PRs: - goharbor#2310: fix secret drift for ArgoCD (fixes goharbor#2263) - goharbor#2307: default image tag to chart appVersion - goharbor#2314: fix rollingUpdate checks for jobservice/registry - goharbor#2312: fix ArgoCD diff in httproute - goharbor#2317: configurable health probe timeoutSeconds/failureThreshold - goharbor#2330: parametrise gracePeriodTerminationSeconds + core startupProbe Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: replace upstream GHA with GHCR OCI release + lint workflows - release.yaml: package and push to oci://ghcr.io/sm-moshi/charts on tag push - lint.yaml: helm lint + template on PRs and sm-moshi/main pushes - Remove upstream-specific workflows (Docker Hub publish, stale issues, integration, unittest) - Add CLAUDE.md with fork maintenance instructions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: replace GitHub Actions with Woodpecker CI pipelines - .woodpecker/lint.yaml: helm lint + template on push/PR - .woodpecker/release.yaml: package, push to ghcr.io/sm-moshi/charts, create GitHub release on tag push - Remove .github/workflows/ (GHA no longer needed) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: use DHI helm 4.1.3 image, pinned by digest Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> build: mark chart as 1.19.0-rc2 to match appVersion v2.15.0-rc2 Chart version should reflect pre-release status while shipping RC images. Will bump to 1.19.0 when Harbor v2.15.0 GA ships. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sm-moshi
added a commit
to sm-moshi/harbor-helm
that referenced
this pull request
Apr 14, 2026
Cherry-picked upstream PRs: - goharbor#2310: fix secret drift for ArgoCD (fixes goharbor#2263) - goharbor#2307: default image tag to chart appVersion - goharbor#2314: fix rollingUpdate checks for jobservice/registry - goharbor#2312: fix ArgoCD diff in httproute - goharbor#2317: configurable health probe timeoutSeconds/failureThreshold - goharbor#2330: parametrise gracePeriodTerminationSeconds + core startupProbe Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: replace upstream GHA with GHCR OCI release + lint workflows - release.yaml: package and push to oci://ghcr.io/sm-moshi/charts on tag push - lint.yaml: helm lint + template on PRs and sm-moshi/main pushes - Remove upstream-specific workflows (Docker Hub publish, stale issues, integration, unittest) - Add CLAUDE.md with fork maintenance instructions Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: replace GitHub Actions with Woodpecker CI pipelines - .woodpecker/lint.yaml: helm lint + template on push/PR - .woodpecker/release.yaml: package, push to ghcr.io/sm-moshi/charts, create GitHub release on tag push - Remove .github/workflows/ (GHA no longer needed) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> ci: use DHI helm 4.1.3 image, pinned by digest Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> build: mark chart as 1.19.0-rc2 to match appVersion v2.15.0-rc2 Chart version should reflect pre-release status while shipping RC images. Will bump to 1.19.0 when Harbor v2.15.0 GA ships. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These options makes sense to be parametrize for huge clusters which may need more time to terminate pods, e.g. during database migrations.