Allow setting resources requests/limits for core pre-upgrade Job#2334
Open
jbuck wants to merge 1 commit intogoharbor:mainfrom
Open
Allow setting resources requests/limits for core pre-upgrade Job#2334jbuck wants to merge 1 commit intogoharbor:mainfrom
jbuck wants to merge 1 commit intogoharbor:mainfrom
Conversation
Signed-off-by: Jon Buckley <jbuckley@mozilla.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows setting the resources requests/limits for core pre-upgrade Job. Our production cluster requires that resources are set for all Pods. I also added a test to confirm it's working as expected, and won't regress.
I decided to re-use the existing core resources declaration looking at the rest of the variables for the pre-upgrade Job, but I can change this code to use a separate variable if that's desired.