Skip to content

Conversation

@stonezdj
Copy link
Contributor

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner September 30, 2025 15:46
@stonezdj stonezdj changed the title Add UI for limit upstream registry connection (cherry-pick) Add UI for limit upstream registry connection Sep 30, 2025
@codecov
Copy link

codecov bot commented Sep 30, 2025

Codecov Report

❌ Patch coverage is 35.00000% with 13 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-2.14.0@815a1a3). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...rojects/create-project/create-project.component.ts 28.57% 8 Missing and 2 partials ⚠️
...t-policy-config/project-policy-config.component.ts 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.14.0   #22410   +/-   ##
=================================================
  Coverage                  ?   65.87%           
=================================================
  Files                     ?     1073           
  Lines                     ?   116018           
  Branches                  ?     2931           
=================================================
  Hits                      ?    76428           
  Misses                    ?    35352           
  Partials                  ?     4238           
Flag Coverage Δ
unittests 65.87% <35.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/portal/src/app/base/project/project.ts 100.00% <100.00%> (ø)
...t-policy-config/project-policy-config.component.ts 52.60% <40.00%> (ø)
...rojects/create-project/create-project.component.ts 48.02% <28.57%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj force-pushed the 2.14_limit_upstream_conn_ui branch 2 times, most recently from 8c80837 to 8b26b07 Compare October 10, 2025 05:21
@stonezdj stonezdj requested a review from MinerYang October 11, 2025 06:24
@stonezdj stonezdj force-pushed the 2.14_limit_upstream_conn_ui branch from 8b26b07 to 0f7255c Compare October 11, 2025 06:30
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj enabled auto-merge (squash) October 11, 2025 06:34
@stonezdj stonezdj merged commit 27b26e2 into goharbor:release-2.14.0 Oct 11, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants