This repository was archived by the owner on Sep 9, 2020. It is now read-only.
[Experimental] status: add an offline mode#1498
Closed
darkowlzz wants to merge 1 commit intogolang:masterfrom
Closed
[Experimental] status: add an offline mode#1498darkowlzz wants to merge 1 commit intogolang:masterfrom
darkowlzz wants to merge 1 commit intogolang:masterfrom
Conversation
a68667f to
a13785e
Compare
Merged
This change divides the huge `runStatusAll()` function into small functions with specific re-usable blocks. The new re-usability enabled addition of an offline status mode which generates the same status only from the manifest and lock file only, without any upstream project knowledge. This offline status is completely compatible with the existing `-json`, `-dot` and `-f` flags.
a13785e to
2f3d7c3
Compare
Member
|
Dep was officially deprecated earlier this year, and the proposal to archive this repository was accepted. As such, I'm closing outstanding issues before archiving the repository. For any further comments, please use the proposal thread on the Go issue tracker. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
This change divides the huge
runStatusAll()function into smallfunctions with specific re-usable blocks. The new re-usability enabled
addition of an offline status mode which generates the same status only
from the manifest and lock file, without any upstream project
knowledge. This offline status is completely compatible with the existing
-json,-dotand-fflags.WHY: This would enable granular testing of each fields in status for various combination of inputs using the
getCompleteStatus()and its returnedbsMap(BasicStatus Map). That would be in a follow-up PR.NOTE: This PR started with the intention to make status output fields more testable, but as a side effect of the changes, adding an offline mode was easy and helped in better organization of code. Offline mode can be removed if it is misleading for the users, just an experiment.
What should your reviewer look out for in this PR?
Names of the new functions and their descriptions.
Is "offline" a good term for this? Maybe something better?
Do you need help or clarification on anything?
Any more possible division of code to create more re-usable and testable functions around
runStatusAll().Which issue(s) does this PR fix?
None.