This repository was archived by the owner on Sep 9, 2020. It is now read-only.
internal/fs: fix os.Chmod on Windows with long paths#925
Merged
ibrasho merged 1 commit intogolang:masterfrom Aug 22, 2017
Merged
internal/fs: fix os.Chmod on Windows with long paths#925ibrasho merged 1 commit intogolang:masterfrom
ibrasho merged 1 commit intogolang:masterfrom
Conversation
ibrasho
force-pushed
the
fix-chmod-on-windows
branch
2 times, most recently
from
40956b4 to
07b9077
Compare
sdboyer
approved these changes
Aug 3, 2017
Member
sdboyer
left a comment
sdboyer
left a comment
There was a problem hiding this comment.
OK, seems fine - i'm just not even gonna try to fully grok all that path manipulation stuff, and trust that if the test you have in there exceeds the 248 length and passes (which it does) then we're 👍 😄
just need rebase now!
ibrasho
force-pushed
the
fix-chmod-on-windows
branch
3 times, most recently
from
98c7da5 to
57b5130
Compare
Member
|
still having an error on windows tests 😢 |
Member
|
bump |
ibrasho
force-pushed
the
fix-chmod-on-windows
branch
3 times, most recently
from
c94cee9 to
220d940
Compare
copy the same functions used in os to convert long paths on Windows to the extended-length form. Fixes golang#774 Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com>
ibrasho
force-pushed
the
fix-chmod-on-windows
branch
from
220d940 to
496e2a0
Compare
Collaborator
Author
|
Turns out the tests were wrong. 😅 @F21 could you test this branch, please? |
|
@ibrasho Just tested your branch and it works correctly! Thank you :) |
markwest1
pushed a commit
to markwest1/dep
that referenced
this pull request
Aug 24, 2017
copy the same functions used in os to convert long paths on Windows to the extended-length form. Fixes golang#774 Signed-off-by: Ibrahim AshShohail <ibra.sho@gmail.com> Document generating graph visualizations golang#975
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
os.Chmoddoesn't work when the passed path is longer than regular path on Windows (<= 248 characters) unless the path in extended-length form.What should your reviewer look out for in this PR?
Correctness.
Which issue(s) does this PR fix?
Fixes #774