Skip to content

benchstat: accept io.Writer in FormatHTML, not *bytes.Buffer #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nvb wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −9
Open

benchstat: accept io.Writer in FormatHTML, not *bytes.Buffer #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions benchstat/html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
package benchstat

import (
"bytes"
"html/template"
"io"
"strings"
)

Expand Down Expand Up @@ -75,12 +75,7 @@ func htmlGroup(rows []*Row) (out [][]*Row) {
return
}

// FormatHTML appends an HTML formatting of the tables to buf.
func FormatHTML(buf *bytes.Buffer, tables []*Table) {
err := htmlTemplate.Execute(buf, tables)
if err != nil {
// Only possible errors here are template not matching data structure.
// Don't make caller check - it's our fault.
panic(err)
}
// FormatHTML appends an HTML formatting of the tables to w.
func FormatHTML(w io.Writer, tables []*Table) {
must(htmlTemplate.Execute(w, tables))
}