Skip to content

Fix autoThemeSwitching when terminal background color hasn't changed but theme is mismatched #20705

@sehoon38

Description

@sehoon38

What happened?

If autoThemeSwitching is enabled and the terminal background color hasn't changed since startup, but the current theme is incorrectly matched with the background (e.g. light theme on dark background), the theme wouldn't switch automatically because of an early return that bypassed the switching logic.

What did you expect to happen?

The theme should automatically switch to the correct theme if the luminance of the terminal background mismatches the current theme, even if the terminal background color hasn't changed since the previous check.

Client information

Client Information N/A - Development environment issue

Login information

Anything else we need to know?

Metadata

Metadata

Assignees

Labels

area/coreIssues related to User Interface, OS Support, Core Functionalitystatus/need-triageIssues that need to be triaged by the triage automation.🔒 maintainer only⛔ Do not contribute. Internal roadmap item.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions