Skip to content

feat: remove deprecated telemetry flags#11318

Merged
allenhutchison merged 1 commit intomainfrom
adh/6707-remove-deprecated-flags
Oct 17, 2025
Merged

feat: remove deprecated telemetry flags#11318
allenhutchison merged 1 commit intomainfrom
adh/6707-remove-deprecated-flags

Conversation

@allenhutchison
Copy link
Copy Markdown
Contributor

Removes the following deprecated telemetry flags from the CLI:

  • --telemetry
  • --telemetry-target
  • --telemetry-otlp-endpoint
  • --telemetry-otlp-protocol
  • --telemetry-log-prompts
  • --telemetry-outfile

These flags have been replaced by settings in the settings.json file.
The related tests have been updated or removed.

Removes the following deprecated telemetry flags from the CLI:
- --telemetry
- --telemetry-target
- --telemetry-otlp-endpoint
- --telemetry-otlp-protocol
- --telemetry-log-prompts
- --telemetry-outfile

These flags have been replaced by settings in the `settings.json` file.
The related tests have been updated or removed.
@allenhutchison allenhutchison requested a review from a team as a code owner October 16, 2025 20:56
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the command-line interface by eliminating deprecated telemetry configuration flags. The functionality previously controlled by these flags is now solely managed via the settings.json file, ensuring a consistent and centralized approach to telemetry configuration. This change simplifies the CLI's argument parsing logic and reduces the surface area for configuration options directly on the command line.

Highlights

  • Deprecated Telemetry Flags Removal: The pull request removes several deprecated telemetry-related CLI flags, including --telemetry, --telemetry-target, --telemetry-otlp-endpoint, --telemetry-otlp-protocol, --telemetry-log-prompts, and --telemetry-outfile.
  • Configuration Centralization: These removed flags have been superseded by equivalent settings that are now managed exclusively through the settings.json file, promoting a centralized configuration approach.
  • Test Suite Updates: Corresponding test cases related to the parsing and handling of these deprecated telemetry flags have been updated or entirely removed to reflect their deprecation and removal from the CLI.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleanly removes several deprecated telemetry-related CLI flags (--telemetry, --telemetry-target, etc.). The changes are well-executed, with corresponding updates to argument parsing, configuration loading, and tests. The removal of the associated test suites for these flags is appropriate, and the remaining tests for environment variable and settings-based configuration appear to be sufficient. The changes are consistent with the goal of migrating telemetry configuration to settings.json and environment variables. I have not identified any high or critical severity issues in this pull request.

@github-actions
Copy link
Copy Markdown

Size Change: -2.1 kB (-0.01%)

Total Size: 17.8 MB

Filename Size Change
./bundle/gemini.js 17.8 MB -2.1 kB (-0.01%)
ℹ️ View Unchanged
Filename Size
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB
./bundle/sandbox-macos-permissive-open.sb 830 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB

compressed-size-action

Copy link
Copy Markdown
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So many deletions!!lgtm

@allenhutchison allenhutchison added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 9049f8f Oct 17, 2025
25 of 26 checks passed
@allenhutchison allenhutchison deleted the adh/6707-remove-deprecated-flags branch October 17, 2025 00:04
Millsondylan pushed a commit to Millsondylan/gemini-cli-1 that referenced this pull request Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants