feat: remove deprecated telemetry flags#11318
Conversation
Removes the following deprecated telemetry flags from the CLI: - --telemetry - --telemetry-target - --telemetry-otlp-endpoint - --telemetry-otlp-protocol - --telemetry-log-prompts - --telemetry-outfile These flags have been replaced by settings in the `settings.json` file. The related tests have been updated or removed.
Summary of ChangesHello @allenhutchison, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the command-line interface by eliminating deprecated telemetry configuration flags. The functionality previously controlled by these flags is now solely managed via the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cleanly removes several deprecated telemetry-related CLI flags (--telemetry, --telemetry-target, etc.). The changes are well-executed, with corresponding updates to argument parsing, configuration loading, and tests. The removal of the associated test suites for these flags is appropriate, and the remaining tests for environment variable and settings-based configuration appear to be sufficient. The changes are consistent with the goal of migrating telemetry configuration to settings.json and environment variables. I have not identified any high or critical severity issues in this pull request.
|
Size Change: -2.1 kB (-0.01%) Total Size: 17.8 MB
ℹ️ View Unchanged
|

Removes the following deprecated telemetry flags from the CLI:
These flags have been replaced by settings in the
settings.jsonfile.The related tests have been updated or removed.