Make compression threshold editable in the UI. by scidomino · Pull Request #12317 · google-gemini/gemini-cli

scidomino · 2025-10-30T21:54:07Z

Summary

Introduce a new setting model.compressionThreshold which can be edited with /settings.

Details

The old settings model.chatCompression.contextPercentageThreshold had two problems:

it wasn't a first class property so it couldn't be edited
it had "percentage" in the name making it sounds like a value between 0-100.

Rather than fixing it I thought it would be easier to just create a new one especially since it is unlikely that we will have many other compression properties.

Related Issues

For https://github.com/google-gemini/maintainers-gemini-cli/issues/973

How to Validate

Change your settings!

Pre-Merge Checklist

github-actions · 2025-10-30T21:56:02Z

Size Change: +81 B (0%)

Total Size: 20.3 MB

ℹ️ View Unchanged

Filename	Size	Change
`./bundle/gemini.js`	20.3 MB	+81 B (0%)
`./bundle/sandbox-macos-permissive-closed.sb`	1.03 kB	0 B
`./bundle/sandbox-macos-permissive-open.sb`	890 B	0 B
`./bundle/sandbox-macos-permissive-proxied.sb`	1.31 kB	0 B
`./bundle/sandbox-macos-restrictive-closed.sb`	3.29 kB	0 B
`./bundle/sandbox-macos-restrictive-open.sb`	3.36 kB	0 B
`./bundle/sandbox-macos-restrictive-proxied.sb`	3.56 kB	0 B

_{compressed-size-action}

scidomino · 2025-10-30T22:15:32Z

/gemini review

gemini-code-assist

Code Review

This pull request successfully introduces a new, editable setting model.compressionThreshold to control chat history compression, replacing the old, less flexible model.chatCompression.contextPercentageThreshold. The changes are well-reflected in the documentation and tests. However, I've identified a couple of issues: a consistent typo in the new setting's name throughout the code, and a lack of validation for the new setting's value, which could lead to unexpected behavior. Addressing these will improve the code's correctness and maintainability.

packages/cli/src/config/settingsSchema.ts

NTaylorMullen

Should address each comment BUT approving to unblock

docs/get-started/configuration.md

packages/cli/src/config/settings.ts

packages/core/src/config/config.ts

abhipatel12 · 2025-10-31T00:37:48Z

/patch preview

github-actions · 2025-10-31T00:38:08Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: preview
Commit: 3332703fca4c8e754a82c0818d62ea5ee386f9e2
Workflows Created: 1

🔗 Track Progress:

github-actions · 2025-10-31T01:47:40Z

🚀 Patch PR Created!

📋 Patch Details:

Channel: preview → will publish to npm tag preview
Commit: 3332703fca4c8e754a82c0818d62ea5ee386f9e2
Hotfix Branch: hotfix/v0.12.0-preview.5/0.12.0-preview.6/preview/cherry-pick-3332703/pr-12317
Hotfix PR: #12334

📝 Next Steps:

Review and approve the hotfix PR: #12334
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #12334

github-actions · 2025-10-31T01:58:51Z

🚀 Patch Release Started!

📋 Release Details:

Environment: prod
Channel: preview → publishing to npm tag preview
Version: v0.12.0-preview.5
Hotfix PR: Merged ✅
Release Branch: release/v0.12.0-preview.5-pr-12317

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

View release workflow

github-actions · 2025-10-31T02:14:54Z

✅ Patch Release Complete!

📦 Release Details:

Version: 0.12.0-preview.6
NPM Tag: preview
Channel: preview
Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

GitHub Release: View release v0.12.0-preview.6
NPM Package: npm install @google/gemini-cli@preview

🔗 Links:

mattKorwel · 2025-10-31T02:42:59Z

/patch stable

github-actions · 2025-10-31T02:43:13Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable
Commit: 3332703fca4c8e754a82c0818d62ea5ee386f9e2
Workflows Created: 1

🔗 Track Progress:

mattKorwel · 2025-10-31T02:49:54Z

/patch stable

github-actions · 2025-10-31T02:50:09Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable
Commit: 3332703fca4c8e754a82c0818d62ea5ee386f9e2
Workflows Created: 1

🔗 Track Progress:

mattKorwel · 2025-10-31T03:10:09Z

Fixed an error where patch was failing due to git hook husky linting validation

mattKorwel · 2025-10-31T03:10:22Z

/patch stable

github-actions · 2025-10-31T03:10:48Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable
Commit: 3332703fca4c8e754a82c0818d62ea5ee386f9e2
Workflows Created: 1

🔗 Track Progress:

# Conflicts: # packages/cli/src/config/config.test.ts # packages/core/src/services/chatCompressionService.test.ts # packages/core/src/services/chatCompressionService.ts

github-actions · 2025-10-31T03:12:00Z

🚀 Patch PR Created!

📋 Patch Details:

Channel: stable → will publish to npm tag latest
Commit: 3332703fca4c8e754a82c0818d62ea5ee386f9e2
Hotfix Branch: hotfix/v0.11.2/0.11.3/stable/cherry-pick-3332703/pr-12317
Hotfix PR: #12340
⚠️ Status: Cherry-pick conflicts detected - manual resolution required

📝 Next Steps:

⚠️ Resolve conflicts in the hotfix PR first: #12340
Test your changes after resolving conflicts
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #12340

gemini-code-assist bot reviewed Oct 30, 2025

View reviewed changes

packages/cli/src/config/settingsSchema.ts Outdated Show resolved Hide resolved

packages/cli/src/config/settingsSchema.ts Outdated Show resolved Hide resolved

scidomino force-pushed the tomm_setting branch from 821d5b5 to ac39bd4 Compare October 30, 2025 22:18

scidomino changed the title ~~Make compression threshold editable in the UI.~~ Make compression threshhold editable in the UI. Oct 30, 2025

scidomino marked this pull request as ready for review October 30, 2025 22:19

scidomino requested a review from a team as a code owner October 30, 2025 22:19

NTaylorMullen approved these changes Oct 30, 2025

View reviewed changes

docs/get-started/configuration.md Outdated Show resolved Hide resolved

packages/cli/src/config/settings.ts Show resolved Hide resolved

scidomino force-pushed the tomm_setting branch from ac39bd4 to 0109b4d Compare October 30, 2025 22:43

Make compression threshold editable in the UI.

4e05db8

scidomino force-pushed the tomm_setting branch from 0109b4d to 4e05db8 Compare October 30, 2025 22:44

scidomino changed the title ~~Make compression threshhold editable in the UI.~~ Make compression threshold editable in the UI. Oct 30, 2025

scidomino enabled auto-merge October 30, 2025 22:46

scidomino added this pull request to the merge queue Oct 30, 2025

jacob314 reviewed Oct 30, 2025

View reviewed changes

packages/core/src/config/config.ts Show resolved Hide resolved

scidomino removed this pull request from the merge queue due to a manual request Oct 30, 2025

scidomino added this pull request to the merge queue Oct 30, 2025

Merged via the queue into main with commit 3332703 Oct 30, 2025
22 checks passed

scidomino deleted the tomm_setting branch October 30, 2025 23:14

anowardear062-svg approved these changes Oct 31, 2025

View reviewed changes

github-actions bot pushed a commit that referenced this pull request Oct 31, 2025

Make compression threshold editable in the UI. (#12317)

5ecc394

scidomino added a commit that referenced this pull request Oct 31, 2025

Make compression threshold editable in the UI. (#12317)

0a3edd6

scidomino added a commit that referenced this pull request Oct 31, 2025

Make compression threshold editable in the UI. (#12317)

ce40a65

IamRiddhi pushed a commit that referenced this pull request Oct 31, 2025

Make compression threshold editable in the UI. (#12317)

4c2cba5

Conversation

scidomino commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scidomino commented Oct 30, 2025

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

NTaylorMullen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

abhipatel12 commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

mattKorwel commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

mattKorwel commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

mattKorwel commented Oct 31, 2025

Uh oh!

mattKorwel commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

github-actions bot commented Oct 31, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

scidomino commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading