feat(sessions): record interactive-only errors and warnings to chat recording JSON files#13300
Conversation
Summary of ChangesHello @bl-ue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the chat recording functionality by ensuring that the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully implements chat recording for UI-specific messages and creates new recording sessions upon using the /clear command. The changes are well-structured and cover session resumption and browser compatibility. However, I found a critical issue in slashCommandProcessor.ts where adding a new parameter to handleSlashCommand has broken the argument passing for recursive calls, which affects commands requiring user confirmation. This needs to be addressed to prevent regressions in functionality.
|
Next: #13351 |
…ecording JSON files (google-gemini#13300)
This PR implements recording of interactive-only messages (e.g.
ℹ Request cancelled.and✕ [API Error: ...]), and makes the/clearcommand start a new chat recording session so that subsequent messages are written to a new JSON file.Note: This PR is the 5th in a series of PRs that implement automatic chat recording and resuming in both interactive and non-interactive modes, with command line flags for non-interactive resuming and session management, and an interactive session browser.
PR #4401 was the original monolithic PR, which implemented this feature from the ground up. It's too large to merge as-is, however, and so it was broken up into several smaller PRs, of which this PR is the 5th.
Please see #4401's description for the full context of this PR. The original monolithic PR's description contains a detailed analysis of the entire system, with an example of the recording JSON and a demo video.