Skip to content

fix(resume): allow passing a prompt via stdin while resuming using --resume#13520

Merged
mrcabbage972 merged 2 commits intogoogle-gemini:mainfrom
Piebald-AI:allow-passing-prompt-via-stdin-for-resume-flag
Nov 25, 2025
Merged

fix(resume): allow passing a prompt via stdin while resuming using --resume#13520
mrcabbage972 merged 2 commits intogoogle-gemini:mainfrom
Piebald-AI:allow-passing-prompt-via-stdin-for-resume-flag

Conversation

@bl-ue
Copy link
Copy Markdown
Contributor

@bl-ue bl-ue commented Nov 20, 2025

Summary

Reported by @arjun810 in #10719 (comment). Thank you @arjun810!

Details

Related Issues

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@bl-ue bl-ue requested a review from a team as a code owner November 20, 2025 18:20
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @bl-ue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the flexibility of the CLI by allowing users to pipe prompt input via stdin when resuming a session in non-interactive environments. This addresses a reported issue where the CLI previously enforced an explicit --prompt argument, improving the command-line tool's usability for automated scripts or complex piping scenarios.

Highlights

  • Enabled Stdin for Resume Prompts: The previous validation that required an explicit --prompt argument when using --resume in non-interactive mode has been removed. This now allows users to provide the prompt via standard input (stdin) instead.
  • Updated Test Case: A corresponding test case in config.test.ts was updated to reflect this new behavior. It now asserts that parseArguments successfully processes a --resume command without an explicit --prompt when process.stdin.isTTY is false, rather than throwing an error.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where a prompt could not be passed via stdin when resuming a session. The change correctly removes a validation check that was preventing this. However, this also removes a safeguard that prevented running a resume command without any prompt in a non-interactive session. I've added a comment suggesting to re-introduce this check at a later stage of execution to maintain good error handling for that edge case.

@bl-ue
Copy link
Copy Markdown
Contributor Author

bl-ue commented Nov 20, 2025

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue where resuming a session with --resume was not possible when providing a prompt via stdin. The change involves removing an overly restrictive validation check in the argument parsing logic. The corresponding test case has been updated to reflect and verify the new, correct behavior. The changes are clean, targeted, and well-tested. This is a good fix.

@mrcabbage972 mrcabbage972 added this pull request to the merge queue Nov 25, 2025
Merged via the queue into google-gemini:main with commit 098e5c2 Nov 25, 2025
21 checks passed
@bl-ue bl-ue deleted the allow-passing-prompt-via-stdin-for-resume-flag branch November 25, 2025 18:05
danpalmer pushed a commit to danpalmer/gemini-cli that referenced this pull request Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants