fix(resume): allow passing a prompt via stdin while resuming using --resume#13520
Conversation
…resume Reported by @arjun810 in google-gemini#10719 (comment). Thank you @arjun810!
Summary of ChangesHello @bl-ue, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the flexibility of the CLI by allowing users to pipe prompt input via stdin when resuming a session in non-interactive environments. This addresses a reported issue where the CLI previously enforced an explicit Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where a prompt could not be passed via stdin when resuming a session. The change correctly removes a validation check that was preventing this. However, this also removes a safeguard that prevented running a resume command without any prompt in a non-interactive session. I've added a comment suggesting to re-introduce this check at a later stage of execution to maintain good error handling for that edge case.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where resuming a session with --resume was not possible when providing a prompt via stdin. The change involves removing an overly restrictive validation check in the argument parsing logic. The corresponding test case has been updated to reflect and verify the new, correct behavior. The changes are clean, targeted, and well-tested. This is a good fix.
Summary
Reported by @arjun810 in #10719 (comment). Thank you @arjun810!
Details
Related Issues
How to Validate
Pre-Merge Checklist