Skip to content

feat: enable extensions to configure includeDirectories#14362

Closed
jsafyan wants to merge 3 commits intogoogle-gemini:mainfrom
jsafyan:extension-include-dirs
Closed

feat: enable extensions to configure includeDirectories#14362
jsafyan wants to merge 3 commits intogoogle-gemini:mainfrom
jsafyan:extension-include-dirs

Conversation

@jsafyan
Copy link

@jsafyan jsafyan commented Dec 2, 2025

Partially addresses #12634. Supersedes #12676.

Implements the context.includeDirectories configuration for extensions, allowing them to contribute to the CLI's context.

  • Adds includeDirectories to GeminiCLIExtension and ExtensionConfig.
  • Updates ExtensionManager to load and resolve these directories (supporting relative paths).
  • Updates loadCliConfig to merge extension directories with user settings.
  • Includes comprehensive tests for path resolution and precedence.

@jsafyan jsafyan requested a review from a team as a code owner December 2, 2025 09:20
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jsafyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new feature that allows Gemini CLI extensions to configure includeDirectories. This enhancement enables extensions to specify directories that should be incorporated into the CLI's context, thereby expanding their ability to influence the CLI's behavior and access relevant files. The changes involve updating configuration interfaces, implementing robust path resolution within the extension manager, and integrating these extension-provided directories into the main CLI configuration, ensuring a seamless and extensible experience.

Highlights

  • Extension Configuration: Extensions can now define includeDirectories within their context configuration, allowing them to contribute specific directories to the CLI's operational context.
  • Path Resolution: The ExtensionManager has been updated to load and correctly resolve these includeDirectories, supporting absolute, home-relative (~), and extension-relative paths.
  • Configuration Merging: The loadCliConfig function now merges includeDirectories specified by active extensions with existing user settings and command-line arguments, ensuring proper precedence.
  • Documentation and Testing: Documentation has been updated to reflect the new context.includeDirectories property, and comprehensive tests have been added to verify path resolution, merging logic, and the exclusion of inactive extension directories.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the ability for extensions to specify includeDirectories to be added to the CLI's context. The implementation correctly handles path resolution for absolute, relative, and tilde-prefixed paths. The changes are well-tested. However, I've identified a security-related issue: the extension installation consent prompt does not inform the user about the directories an extension will add to the context. This should be addressed to ensure users are fully aware of an extension's capabilities before installation.

@chrstnb chrstnb requested review from galz10 and removed request for galz10 December 15, 2025 19:15
@gemini-cli gemini-cli bot added status/need-issue Pull requests that need to have an associated issue. priority/p1 Important and should be addressed in the near term. area/extensibility and removed status/need-issue Pull requests that need to have an associated issue. labels Jan 7, 2026
@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Jan 10, 2026
@bdmorgan
Copy link
Collaborator

Hi @jsafyan, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@sehoon38 sehoon38 requested a review from a team as a code owner January 21, 2026 04:12
@gemini-cli gemini-cli bot added priority/p2 Important but can be addressed in a future release. help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Jan 23, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Jan 24, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details, see the GitHub Documentation.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Jan 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! priority/p1 Important and should be addressed in the near term. priority/p2 Important but can be addressed in a future release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants