feat: enable extensions to configure includeDirectories#14362
feat: enable extensions to configure includeDirectories#14362jsafyan wants to merge 3 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @jsafyan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new feature that allows Gemini CLI extensions to configure Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds the ability for extensions to specify includeDirectories to be added to the CLI's context. The implementation correctly handles path resolution for absolute, relative, and tilde-prefixed paths. The changes are well-tested. However, I've identified a security-related issue: the extension installation consent prompt does not inform the user about the directories an extension will add to the context. This should be addressed to ensure users are fully aware of an extension's capabilities before installation.
|
Hi @jsafyan, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. You can easily reopen this PR once you have linked it to an issue. How to link an issue: Thank you for your understanding and for being a part of our community! |
Partially addresses #12634. Supersedes #12676.
Implements the
context.includeDirectoriesconfiguration for extensions, allowing them to contribute to the CLI's context.includeDirectoriestoGeminiCLIExtensionandExtensionConfig.ExtensionManagerto load and resolve these directories (supporting relative paths).loadCliConfigto merge extension directories with user settings.