feat(cli): support git submodules in extension installation#18387
feat(cli): support git submodules in extension installation#18387thoreinstein wants to merge 1 commit intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @thoreinstein, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the CLI's extension installation mechanism by integrating Git submodule support. This change addresses the common scenario where extensions depend on shared libraries or assets managed as submodules, ensuring a complete and functional installation experience for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces the functionality to initialize and update Git submodules recursively when cloning a repository. Specifically, a call to git.submoduleUpdate(['--init', '--recursive']) has been added to the cloneFromGit function in packages/cli/src/config/extensions/github.ts. Corresponding unit tests in packages/cli/src/config/extensions/github.test.ts were updated to mock and assert the invocation of this new submodule update command. There are no review comments provided for these changes.
|
Hi there! Thank you for your contribution to Gemini CLI. We really appreciate the time and effort you've put into this pull request. To keep our backlog manageable and ensure we're focusing on current priorities, we are closing pull requests that haven't seen maintainer activity for 30 days. Currently, the team is prioritizing work associated with 🔒 maintainer only or help wanted issues. If you believe this change is still critical, please feel free to comment with updated details. Otherwise, we encourage contributors to focus on open issues labeled as help wanted. Thank you for your understanding! |
Summary
Supports recursive cloning and initialization of Git submodules when installing extensions. This ensures that extensions relying on submodules (e.g., for shared libraries or assets) are fully functional immediately after installation.
Details
packages/cli/src/config/extensions/github.tsto initialize submodules after checkout.packages/cli/src/config/extensions/github.test.ts.Related Issues
Closes #18385
How to Validate
npm run buildnpm test -w @google/gemini-cli -- src/config/extensions/github.test.tsPre-Merge Checklist