Skip to content

feat(cli): update approval modes UI#18476

Merged
jerop merged 4 commits intomainfrom
feat/update-approval-ui
Feb 7, 2026
Merged

feat(cli): update approval modes UI#18476
jerop merged 4 commits intomainfrom
feat/update-approval-ui

Conversation

@jerop
Copy link
Contributor

@jerop jerop commented Feb 6, 2026

  • Show the approval mode indicator and hints.
  • Standardize shortcut hint to 'shift+tab'. Note: shift+tab cycles out of YOLO but not into it.

Closes #18473


image image image image

- Rename approval modes: Default -> Build, Auto Edit -> Auto, Plan Mode -> Plan, YOLO mode -> YOLO.
- Always show the approval mode indicator (Build mode is now visible by default).
- Standardize shortcut hint to 'shift+tab'. Note: shift+tab cycles out of YOLO but not into it.
- Update tests to reflect UI changes.

Closes #18473
@jerop jerop requested a review from a team as a code owner February 6, 2026 21:13
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 6, 2026

Hi @jerop, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 6, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Feb 6, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @jerop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user interface for approval modes within the CLI. The changes aim to provide a more intuitive and consistent experience by clarifying mode names, ensuring the approval mode indicator is always displayed, and standardizing the associated shortcut hints. These updates contribute to a more user-friendly and transparent interaction with the CLI's approval workflow.

Highlights

  • Approval Mode Renaming: Renamed several approval modes for improved clarity: 'Default' is now 'Build', 'Auto Edit' is 'Auto', 'Plan Mode' is 'Plan', and 'YOLO mode' is simply 'YOLO'.
  • Persistent Approval Mode Indicator: The approval mode indicator is now always visible, including for the 'Build' mode, providing continuous feedback on the current operational state.
  • Standardized Shortcut Hint: The shortcut hint displayed for cycling through approval modes has been standardized to 'shift+tab' across all modes.
  • Test Updates: Unit tests have been updated to reflect the new approval mode names, standardized shortcut hints, and the change in indicator visibility logic.
Changelog
  • packages/cli/src/ui/components/ApprovalModeIndicator.test.tsx
    • Updated test assertions to match the new approval mode names ('Auto', 'Plan', 'YOLO', 'Build') and the standardized 'shift+tab' shortcut hint.
    • Modified the test for DEFAULT mode to assert its visibility and display of 'Build' and 'shift+tab'.
  • packages/cli/src/ui/components/ApprovalModeIndicator.tsx
    • Adjusted textContent for AUTO_EDIT, PLAN, and YOLO modes to their new, shorter names.
    • Standardized subText to ' shift+tab' for all modes.
    • Added specific textColor, textContent ('Build'), and subText for the DEFAULT approval mode, making it visible by default.
  • packages/cli/src/ui/components/Composer.test.tsx
    • Refactored the test for ApprovalModeIndicator visibility to use it.each to cover all ApprovalMode states, confirming the indicator is always shown when shellModeActive is false.
  • packages/cli/src/ui/components/Composer.tsx
    • Removed an unused import for ApprovalMode.
    • Modified the showApprovalIndicator logic to always return true when uiState.shellModeActive is false, ensuring the indicator is perpetually displayed.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@jerop jerop reopened this Feb 6, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 6, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@gemini-cli gemini-cli bot added area/core Issues related to User Interface, OS Support, Core Functionality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels Feb 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the UI for approval modes by renaming them, making the indicator always visible, and standardizing the shortcut hint. The changes are well-implemented across the component, its tests, and its usage in the Composer. The tests have been effectively updated to reflect the new UI behavior. I've kept the suggestion to improve maintainability by reducing code duplication in the ApprovalModeIndicator component.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Size Change: +231 B (0%)

Total Size: 23.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.8 MB +231 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@jerop jerop enabled auto-merge February 6, 2026 21:18
@jerop jerop force-pushed the feat/update-approval-ui branch from 77cbfe4 to dc9c473 Compare February 6, 2026 22:55
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jerop jerop added this pull request to the merge queue Feb 6, 2026
@jerop jerop removed this pull request from the merge queue due to a manual request Feb 6, 2026
jerop added 2 commits February 6, 2026 18:51
- Updated cycle: default -> plan -> auto-edit -> default.
- Standardized hints: 'shift + tab to enter <mode> mode'.
- Use 'auto-edit' instead of 'accept edits'.
- Replaced 'build mode' references with 'default mode'.
- Updated all related tests.
@jerop jerop enabled auto-merge February 7, 2026 00:06
@jerop jerop added this pull request to the merge queue Feb 7, 2026
Merged via the queue into main with commit 3b0649d Feb 7, 2026
27 checks passed
@jerop jerop deleted the feat/update-approval-ui branch February 7, 2026 00:35
aswinashok44 pushed a commit to aswinashok44/gemini-cli that referenced this pull request Feb 9, 2026
kuishou68 pushed a commit to iOfficeAI/aioncli that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the approval modes UI

2 participants