Conversation
- Rename approval modes: Default -> Build, Auto Edit -> Auto, Plan Mode -> Plan, YOLO mode -> YOLO. - Always show the approval mode indicator (Build mode is now visible by default). - Standardize shortcut hint to 'shift+tab'. Note: shift+tab cycles out of YOLO but not into it. - Update tests to reflect UI changes. Closes #18473
|
Hi @jerop, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jerop, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the user interface for approval modes within the CLI. The changes aim to provide a more intuitive and consistent experience by clarifying mode names, ensuring the approval mode indicator is always displayed, and standardizing the associated shortcut hints. These updates contribute to a more user-friendly and transparent interaction with the CLI's approval workflow. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Thank you for linking an issue! This pull request has been automatically reopened. |
There was a problem hiding this comment.
Code Review
This pull request updates the UI for approval modes by renaming them, making the indicator always visible, and standardizing the shortcut hint. The changes are well-implemented across the component, its tests, and its usage in the Composer. The tests have been effectively updated to reflect the new UI behavior. I've kept the suggestion to improve maintainability by reducing code duplication in the ApprovalModeIndicator component.
|
Size Change: +231 B (0%) Total Size: 23.8 MB ℹ️ View Unchanged
|
77cbfe4 to
dc9c473
Compare
- Updated cycle: default -> plan -> auto-edit -> default. - Standardized hints: 'shift + tab to enter <mode> mode'. - Use 'auto-edit' instead of 'accept edits'. - Replaced 'build mode' references with 'default mode'. - Updated all related tests.

Closes #18473