Skip to content

fix(patch): cherry-pick 07056c8 to release/v0.27.3-pr-18656 to patch version v0.27.3 and create version 0.27.4#18671

Closed
gemini-cli-robot wants to merge 1 commit intorelease/v0.27.3-pr-18656from
hotfix/v0.27.3/0.27.4/stable/cherry-pick-07056c8/pr-18656
Closed

fix(patch): cherry-pick 07056c8 to release/v0.27.3-pr-18656 to patch version v0.27.3 and create version 0.27.4#18671
gemini-cli-robot wants to merge 1 commit intorelease/v0.27.3-pr-18656from
hotfix/v0.27.3/0.27.4/stable/cherry-pick-07056c8/pr-18656

Conversation

@gemini-cli-robot
Copy link
Collaborator

This PR automatically cherry-picks commit 07056c8 to patch version v0.27.3 in the stable release to create version 0.27.4.

@gemini-cli-robot gemini-cli-robot requested a review from a team as a code owner February 9, 2026 21:09
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gemini-cli-robot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical fix to improve the robustness of API response processing within the core package. It ensures that the fromGenerateContentResponse function can safely handle malformed or incomplete responses by providing default values, thereby enhancing the stability of the application when interacting with external services. This change is being cherry-picked to patch a stable release.

Highlights

  • Robust API Response Handling: The fromGenerateContentResponse utility now gracefully handles cases where the incoming CaGenerateContentResponse object might be missing its response property, preventing potential runtime errors and ensuring a consistent output structure.
  • Enhanced Test Coverage: A new test case has been added to converter.test.ts specifically to validate the robust handling of missing response properties, ensuring the function returns an empty candidates array and correctly assigns the traceId.
Changelog
  • packages/core/src/code_assist/converter.test.ts
    • Added a new test case (should handle missing response property gracefully) to converter.test.ts to verify that fromGenerateContentResponse correctly processes CaGenerateContentResponse objects that lack the response property, ensuring candidates is an empty array and responseId is set from traceId.
  • packages/core/src/code_assist/converter.ts
    • Modified the fromGenerateContentResponse function to explicitly check if res.response is defined. If it's not, out.candidates is initialized as an empty array, preventing null or undefined access errors.
    • Reordered the assignment of out.responseId to res.traceId to occur before accessing res.response.
Activity
  • This pull request was automatically generated by gemini-cli-robot to cherry-pick commit 07056c8f16a9340aedcc716a5c247da07c135cf2 to the release/v0.27.3-pr-18656 branch.
  • The purpose is to create a patch version v0.27.4 for the stable release v0.27.3.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@skeshive skeshive enabled auto-merge (squash) February 9, 2026 21:10
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cherry-picks a fix to gracefully handle malformed CaGenerateContentResponse objects that may be missing the response property. The change in fromGenerateContentResponse prevents a potential runtime error by checking for the existence of res.response and providing a safe default. A new test case has been added to verify this behavior. The fix is correct and improves the robustness of the response conversion logic. The changes look good.

@github-actions
Copy link

github-actions bot commented Feb 9, 2026

Size Change: +67 B (0%)

Total Size: 23.5 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.5 MB +67 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@skeshive skeshive closed this Feb 9, 2026
auto-merge was automatically disabled February 9, 2026 21:16

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants