Revert "Add generic searchable list to back settings and extensions (…

[chrstnb]

…#18838)"

This reverts commit 991b2c6.

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change that introduced a generic SearchableList component and a useFuzzyList hook. While the generic components have been removed, the core search functionality for the settings dialog has been re-implemented directly within the SettingsDialog component. This change aims to streamline the implementation of search within the settings, moving away from a shared generic component towards a more tailored, integrated solution.

Highlights

• Reverted Generic Searchable List: The generic SearchableList component and its associated useFuzzyList hook have been removed, reverting a previous commit.
• Internalized Search Logic in SettingsDialog: The SettingsDialog component has been refactored to directly implement fuzzy search functionality using AsyncFzf and useTextBuffer, rather than relying on the previously removed generic components.
• Improved List Navigation Logic: Adjustments were made in BaseSettingsDialog to refine how active item focus and scroll position are maintained when the list of items changes.

Changelog

• packages/cli/src/ui/components/SettingsDialog.tsx
  • Removed dependencies on useFuzzyList and SearchableList.
  • Introduced direct fuzzy search implementation using AsyncFzf and useTextBuffer.
  • Added FzfResult interface for search results.
  • Implemented search state management and filtering logic.
  • Calculated maxLabelOrDescriptionWidth for UI alignment.
  • Integrated useTextBuffer for search input.
• packages/cli/src/ui/components/shared/BaseSettingsDialog.tsx
  • Refined the logic for maintaining active item focus and scroll position when the list of items changes.
  • Simplified keypress activation logic by removing a priority condition.
• packages/cli/src/ui/components/shared/SearchableList.test.tsx
  • Removed the test file for the SearchableList component.
• packages/cli/src/ui/components/shared/SearchableList.tsx
  • Removed the SearchableList component file.
• packages/cli/src/ui/hooks/useFuzzyList.ts
  • Removed the useFuzzyList hook file.

Activity

• The pull request was created by chrstnb to revert a previous commit.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -487 B (0%)

Total Size: 24.5 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	24.5 MB	-487 B (0%)
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request reverts the introduction of a generic searchable list component and its associated hook, moving the fuzzy search logic back into the SettingsDialog component. While the revert aims to restore previous behavior, the manual implementation of search and focus management introduces some inefficiencies and minor regressions in UI behavior, such as non-optimal scroll indicator logic and missing key handling returns. All original comments are kept as they do not contradict any provided rules and offer valid improvements.

[gemini-code-assist]

The settingKeys variable is calculated on every render, and since it's used as a dependency for the items useMemo below, it causes the items array to be re-created every time SettingsDialog renders. This in turn triggers the useEffect in BaseSettingsDialog that manages focus and scroll offsets, leading to unnecessary O(N) computations on every render. Wrapping this logic in a useMemo would improve performance and prevent redundant effect executions.

Suggested change

	const settingKeys = searchQuery ? filteredKeys : getDialogSettingKeys();
	const settingKeys = useMemo(() => searchQuery ? filteredKeys : getDialogSettingKeys(), [searchQuery, filteredKeys]);