Conversation
|
Hi @jkcinouye, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello @jkcinouye, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation for Gemini CLI's tool system by creating a dedicated and comprehensive tools reference. The changes involve consolidating and expanding existing information into a new, well-structured document, improving clarity and accessibility for users and developers alike. This refactoring ensures that all relevant details about tool functionality, categories, and extensibility are presented in a single, easy-to-navigate location. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great documentation refactoring, creating a new comprehensive tools.md reference page and removing the outdated tools-api.md. The new documentation is well-structured and provides a much clearer overview of the available tools. I've identified one high-severity issue where the new documentation for the /tools command incorrectly describes its functionality regarding MCP tools, which could lead to user confusion.
|
Size Change: -2 B (0%) Total Size: 25.8 MB ℹ️ View Unchanged
|
|
I think once the conflicts are resolved it will be easier for to do a final review and stage. Lot of conflicts when my sidebar update/ top level tabs change went in, sorry! |
|
Build failed: Build process failed with link errors: |
There was a problem hiding this comment.
Code Review
This pull request successfully consolidates the tools documentation into a single, comprehensive reference page, with the new tools.md file being well-structured and handling redirects and link updates correctly. However, a security audit identified two high-severity vulnerabilities: the web_fetch tool is vulnerable to Server-Side Request Forgery (SSRF) due to allowing local/private network access, which could be exploited via prompt injection for data exfiltration. Additionally, the "Trusted folders" mechanism is susceptible to environment variable injection, where malicious .env files could lead to Remote Code Execution (RCE) via variables like NODE_OPTIONS. Recommendations include implementing blocklists for network addresses and environment variables. Furthermore, inconsistencies in tool parameter documentation for read_file and replace tools, and some broken links in the new reference table require attention to ensure the document's accuracy and completeness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Summary
Consolidates tools pages into a single tools reference page.
Details
This page creates a consolidated list of our current tools which links out to smaller tools.
Related Issues
Fixes #19471
How to Validate
This is a docs-only change. Validate that there are no unintended changes, that the content is correct, and that it stages properly.
Pre-Merge Checklist