fix(cli): expose model.name setting in settings dialog for persistence#19605
fix(cli): expose model.name setting in settings dialog for persistence#19605Adib234 merged 5 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @achaljhawar, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by enabling persistent configuration of the Gemini model within the CLI. By making the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly exposes the model.name setting in the settings dialog, which allows users to persist their preferred Gemini model across sessions. The change is straightforward, limited to enabling the setting in the UI and updating the corresponding documentation. This successfully addresses the issue of model selection not being persistent. The implementation is consistent with how other settings are defined in the project. The changes look good and I don't see any high or critical issues.
|
cc @bdmorgan (tagging for better visibility) |
b765fb8
Summary
Expose the model.name setting in the /settings dialog so users can persist their preferred Gemini model across sessions.
Details
The model.name setting in settingsSchema.ts had showInDialog: false, which hid it from the /settings UI. Users had no way to set a persistent default model through the interactive dialog, so model selection was lost between sessions.
This change flips showInDialog to true and regenerates the settings documentation to include the new Model row.
Related Issues
Fixes #17987
How to Validate
Pre-Merge Checklist