chore(dev): update vscode settings for typescriptreact#19907
chore(dev): update vscode settings for typescriptreact#19907jacob314 merged 6 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello @rohit-4321, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the development environment by ensuring consistent code formatting for TypeScript React files within VS Code. By explicitly setting Prettier as the default formatter for Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the .vscode/settings.json file to include a formatter configuration for typescriptreact. This ensures that .tsx files are consistently formatted using the Prettier extension, matching the existing setup for standard TypeScript files. The change is correct and follows VS Code configuration standards for React-based TypeScript projects.
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. |
There was a problem hiding this comment.
Code Review
The pull request correctly updates the .vscode/settings.json file to include [typescriptreact] for Prettier formatting, which aligns with the project's technology stack (TypeScript and React). This change ensures consistent code formatting for .tsx files within VS Code, improving maintainability and adherence to the project's coding style.
| "[typescriptreact]": { | ||
| "editor.defaultFormatter": "esbenp.prettier-vscode" | ||
| }, |
There was a problem hiding this comment.
This addition correctly configures Prettier as the default formatter for .tsx files. This aligns with the project's stated main technologies (TypeScript and React) and the development convention to adhere to existing patterns and coding style (Repository Style Guide, line 73). This ensures consistent formatting across the codebase for React components written in TypeScript.
References
- Adhere to existing patterns in
packages/cli(React/Ink) andpackages/core(Backend logic). (link)
There was a problem hiding this comment.
I've already provided my review on this change. If you have any specific technical questions about my previous comment or the code, please let me know.
|
cc @bdmorgan (tagging for better visibility) |

Related Issue:
Fix #19909
Description
This PR updates the development environment configuration to ensure
.tsxfiles are formatted correctly.Changes:
[typescriptreact]to.vscode/settings.jsonto set Prettier as the default formatter for React TypeScript files.