Skip to content

chore(dev): update vscode settings for typescriptreact#19907

Merged
jacob314 merged 6 commits intogoogle-gemini:mainfrom
rohit-4321:rohit/fix/vscode-setting-json-update
Mar 4, 2026
Merged

chore(dev): update vscode settings for typescriptreact#19907
jacob314 merged 6 commits intogoogle-gemini:mainfrom
rohit-4321:rohit/fix/vscode-setting-json-update

Conversation

@rohit-4321
Copy link
Contributor

@rohit-4321 rohit-4321 commented Feb 22, 2026

Related Issue:

Fix #19909

Description

This PR updates the development environment configuration to ensure .tsx files are formatted correctly.

Changes:

  • Dev: Added [typescriptreact] to .vscode/settings.json to set Prettier as the default formatter for React TypeScript files.

@rohit-4321 rohit-4321 requested a review from a team as a code owner February 22, 2026 13:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rohit-4321, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the development environment by ensuring consistent code formatting for TypeScript React files within VS Code. By explicitly setting Prettier as the default formatter for .tsx files, it standardizes code style, reduces formatting discrepancies, and improves overall code readability for the project.

Highlights

  • VS Code Configuration: Configured Prettier as the default formatter for [typescriptreact] files in .vscode/settings.json.
Changelog
  • .vscode/settings.json
    • Added a new configuration entry for [typescriptreact] to specify Prettier as the default formatter.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .vscode/settings.json file to include a formatter configuration for typescriptreact. This ensures that .tsx files are consistently formatted using the Prettier extension, matching the existing setup for standard TypeScript files. The change is correct and follows VS Code configuration standards for React-based TypeScript projects.

@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 22, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly updates the .vscode/settings.json file to include [typescriptreact] for Prettier formatting, which aligns with the project's technology stack (TypeScript and React). This change ensures consistent code formatting for .tsx files within VS Code, improving maintainability and adherence to the project's coding style.

Comment on lines +10 to +12
"[typescriptreact]": {
"editor.defaultFormatter": "esbenp.prettier-vscode"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This addition correctly configures Prettier as the default formatter for .tsx files. This aligns with the project's stated main technologies (TypeScript and React) and the development convention to adhere to existing patterns and coding style (Repository Style Guide, line 73). This ensures consistent formatting across the codebase for React components written in TypeScript.

References
  1. Adhere to existing patterns in packages/cli (React/Ink) and packages/core (Backend logic). (link)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/gemini review

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've already provided my review on this change. If you have any specific technical questions about my previous comment or the code, please let me know.

@gemini-cli gemini-cli bot added area/core Issues related to User Interface, OS Support, Core Functionality and removed status/need-issue Pull requests that need to have an associated issue. labels Feb 22, 2026
@rohit-4321
Copy link
Contributor Author

cc @bdmorgan (tagging for better visibility)

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacob314 jacob314 enabled auto-merge February 26, 2026 19:20
@gemini-cli gemini-cli bot added priority/p3 Backlog - a good idea but not currently a priority. help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! labels Feb 26, 2026
@jacob314 jacob314 added this pull request to the merge queue Mar 4, 2026
Merged via the queue into google-gemini:main with commit 94ba7ec Mar 4, 2026
27 checks passed
neeraj-par pushed a commit to neeraj-par/gemini-cli that referenced this pull request Mar 4, 2026
BryanBradfo pushed a commit to BryanBradfo/gemini-cli that referenced this pull request Mar 5, 2026
struckoff pushed a commit to struckoff/gemini-cli that referenced this pull request Mar 6, 2026
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality help wanted We will accept PRs from all issues marked as "help wanted". Thanks for your support! priority/p3 Backlog - a good idea but not currently a priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing [typescriptreact] formatter in .vscode/settings.json

2 participants