Plumb the maxAttempts setting through Config args

[kevinjwang1]

Summary

MaxAttempts was accidentally not included in the args for the loaded Config object.

Also modify maxAttempt setting to now show up in the dialog box

Related Issues

Related to #20063

[gemini-code-assist]

Summary of Changes

Hello @kevinjwang1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an oversight where the maxAttempts setting was not being correctly plumbed through to the Config object during its loading process. By including this argument, the system will now properly respect the configured maximum number of attempts for operations, enhancing reliability and adherence to specified retry policies.

Highlights

• Configuration Argument Fix: The maxAttempts setting, which was previously overlooked, is now correctly passed as an argument to the loaded Config object, ensuring proper retry behavior.

Changelog

• packages/cli/src/config/config.ts
  • Included maxAttempts from settings.general in the loadCliConfig function arguments.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly plumbs the maxAttempts setting from the general configuration through to the core Config object. The change is straightforward and properly passes the settings.general?.maxAttempts value during Config instantiation. This ensures that the user-defined maximum number of retry attempts is respected by the application. The implementation is correct and I see no issues.