Fix bottom border rendering for search and add a regression test.

[jacob314]

Summary

Fixes #20516 and adds a regression test

[github-actions]

You already have 7 pull requests open. Please work on getting existing PRs merged before opening more.

[gemini-cli]

Thank you for linking an issue! This pull request has been automatically reopened.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a visual bug affecting the bottom border rendering of search components and introduces a new regression test to maintain the fix. It also updates the project's testing strategy by adopting SVG snapshots for UI components to improve visual test reliability. Furthermore, the logic for determining tool group border styles has been enhanced to accurately reflect the state of pending and empty tool groups.

Highlights

• Border Rendering Fix: Fixed an issue where the bottom border for search components was not rendering correctly, ensuring visual consistency.
• Regression Testing: Added a regression test to prevent future occurrences of the bottom border rendering issue in search components.
• SVG Snapshot Adoption: Introduced and documented the use of SVG snapshots for UI components, particularly for visual layout and color accuracy, replacing previous snapshot methods.
• Tool Group Border Logic: Refined the logic for determining the appearance of tool group borders, ensuring that empty tool groups are correctly handled when identifying the last pending tool.

Changelog

• packages/cli/GEMINI.md
  • Updated testing guidelines to include instructions for using SVG snapshots for UI components.
• packages/cli/src/test-utils/render.tsx
  • Added bannerData and bannerVisible properties to baseMockUiState for mocking UI banner states.
• packages/cli/src/ui/utils/snapshots/InlineMarkdownRenderer.test.tsx.snap
  • Removed old snapshot file.
• packages/cli/src/ui/utils/snapshots/MarkdownDisplay.test.tsx.snap
  • Removed old snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-handles-non-ASCII-characters-emojis-.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-handles-wrapped-bold-headers-without-showing-markers.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-a-3x3-table-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-a-complex-table-with-mixed-content-lengths-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-a-table-with-long-headers-and-4-columns-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-a-table-with-mixed-emojis-As-.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-a-table-with-only-Asian-chara-.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-a-table-with-only-emojis-and-.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-correctly-when-headers-are-em-.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-renders-correctly-when-there-are-more-.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-strips-bold-markers-from-headers-and-renders-them-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-wraps-all-long-columns-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-wraps-columns-with-punctuation-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-wraps-long-cell-content-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer-TableRenderer-wraps-mixed-long-and-short-columns-correctly.snap.svg
  • Removed old SVG snapshot file.
• packages/cli/src/ui/utils/snapshots/TableRenderer.test.tsx.snap
  • Removed old snapshot file.
• packages/cli/src/ui/utils/snapshots/borderStyles-MainContent-tool-group-border-SVG-snapshots-should-render-SVG-snapshot-for-a-pending-search-dialog-google_web_search-.snap.svg
  • Added new SVG snapshot for a pending search dialog.
• packages/cli/src/ui/utils/snapshots/borderStyles-MainContent-tool-group-border-SVG-snapshots-should-render-SVG-snapshot-for-a-shell-tool.snap.svg
  • Added new SVG snapshot for a shell tool.
• packages/cli/src/ui/utils/snapshots/borderStyles-MainContent-tool-group-border-SVG-snapshots-should-render-SVG-snapshot-for-an-empty-slice-following-a-search-tool.snap.svg
  • Added new SVG snapshot for an empty slice following a search tool.
• packages/cli/src/ui/utils/snapshots/borderStyles.test.tsx.snap
  • Added new snapshot file for border styles tests.
• packages/cli/src/ui/utils/snapshots/terminalSetup.test.ts.snap
  • Removed old snapshot file.
• packages/cli/src/ui/utils/snapshots/textOutput.test.ts.snap
  • Removed old snapshot file.
• packages/cli/src/ui/utils/borderStyles.test.tsx
  • Added new test file to verify tool group border appearances and SVG snapshots.
• packages/cli/src/ui/utils/borderStyles.ts
  • Updated the getToolGroupBorderAppearance function to filter out empty tool groups when determining the last pending tool.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly fixes a border rendering issue for tool groups by ensuring that empty tool group slices are ignored when determining border styles. The addition of unit and SVG snapshot tests provides good regression coverage for this fix. However, a large number of unrelated snapshot files have been removed without explanation, which is a major concern. This makes the PR unfocused and raises questions about whether test coverage has been inadvertently reduced.

[github-actions]

Size Change: +21 B (0%)

Total Size: 25.7 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.2 MB	+21 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[jackwotherspoon]

LGTM ✅