feat: Implement slash command handling in ACP for /memory,/init,/extensions and /restore#20528
feat: Implement slash command handling in ACP for /memory,/init,/extensions and /restore#20528
/memory,/init,/extensions and /restore#20528Conversation
|
Hi @sripasg, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Agent Client Protocol (ACP) integration by enabling the direct handling of several core Gemini CLI slash commands within supported editors. It establishes a robust mechanism to inform clients about available commands, intercepts user input to identify and execute these commands, and provides a mocked environment for command execution, ensuring a seamless and interactive experience for users without involving the LLM for command processing. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces slash command handling for /memory, /init, /extensions, and /restore within the ACP integration. My review focuses on improving maintainability by addressing hardcoded values for command descriptions and enhancing robustness by completing the mockUi object to prevent runtime errors from unimplemented UI methods. Both comments align with general best practices and do not contradict any specific rules.
|
Size Change: +9.82 kB (+0.04%) Total Size: 25.8 MB
ℹ️ View Unchanged
|
…sions` and `/restore`,and also send available commands to the client.
…/extensions` and `/restore` (#20528)
…/extensions` and `/restore` (google-gemini#20528)
…/extensions` and `/restore` (google-gemini#20528)
…/extensions` and `/restore` (google-gemini#20528)
…/extensions` and `/restore` (google-gemini#20528)
Summary
/memory,/extensions,/restore, and/init) into the ACP support. These are initially being made available. They are currently available via A2A.Details
The implementation achieves this through three main additions in
packages/cli/src/zed-integration/zedIntegration.ts:1. Decoupling Execution from Presentation
2. A Structured Command Pipeline
We introduced a structured pipeline:
Related Issues
Fixes https://github.com/google-gemini/maintainers-gemini-cli/issues/1331
How to Validate
Pre-Merge Checklist