feat: better error messages by gsquared94 · Pull Request #20577 · google-gemini/gemini-cli

gsquared94 · 2026-02-27T16:58:44Z

No description provided.

gemini-code-assist · 2026-02-27T16:59:20Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly improves the clarity and actionability of authentication error messages within the CLI. By introducing a specific error type and a dedicated user interface for account suspensions, users will receive precise information and direct options (like appealing a suspension or changing authentication) when their access is restricted due to Terms of Service violations. This change enhances the overall user experience by moving beyond generic error messages to provide targeted support for critical authentication issues.

Highlights

Enhanced Authentication Error Handling: The system now specifically identifies and processes account suspension errors (TOS_VIOLATION) during the initial authentication flow.
New AccountSuspendedError Type: A dedicated error class AccountSuspendedError has been introduced in the core utility library to encapsulate details about account suspensions, including appeal URLs.
Dedicated UI for Suspended Accounts: A new BannedAccountDialog component provides a user-friendly interface to display suspension messages, appeal links, and options to change authentication or exit.
Updated Authentication Flow: The performInitialAuth function now returns a comprehensive InitialAuthResult object, containing both general authentication errors and specific account suspension information.
Integration Across CLI Components: Various CLI components, including initializeApp, useAuthCommand, and DialogManager, have been updated to correctly handle and display the new account suspension state.

Changelog

packages/cli/src/core/auth.test.ts
- Updated authentication test expectations to match the new InitialAuthResult structure and added a test case for TOS_VIOLATION errors.
packages/cli/src/core/auth.ts
- Modified performInitialAuth to return an InitialAuthResult object, incorporating authError and accountSuspensionInfo, and integrated isAccountSuspendedError for specific error detection.
packages/cli/src/core/initializer.test.ts
- Adjusted tests for initializeApp to align with the updated return type of performInitialAuth.
packages/cli/src/core/initializer.ts
- Updated initializeApp to destructure authError and accountSuspensionInfo from the authentication result and extended the InitializationResult interface.
packages/cli/src/gemini.test.tsx
- Modified mockInitializationResult to include the new accountSuspensionInfo property.
packages/cli/src/test-utils/AppRig.tsx
- Updated the useAuth mock and initializationResult to support accountSuspensionInfo and its setter.
packages/cli/src/test-utils/render.tsx
- Added clearAccountSuspension to the mockUIActions object.
packages/cli/src/ui/AppContainer.tsx
- Updated the useAuthCommand hook call to pass accountSuspensionInfo and integrated clearAccountSuspension into the UIActionsContext.
packages/cli/src/ui/auth/BannedAccountDialog.test.tsx
- Added a new test file to thoroughly test the BannedAccountDialog component's rendering, interaction, and error handling.
packages/cli/src/ui/auth/BannedAccountDialog.tsx
- Implemented a new React component BannedAccountDialog to display account suspension details, including appeal URLs, and provide interactive options.
packages/cli/src/ui/auth/snapshots/BannedAccountDialog.test.tsx.snap
- Added a snapshot for the BannedAccountDialog component's rendered output.
packages/cli/src/ui/auth/useAuth.ts
- Enhanced the useAuthCommand hook to manage accountSuspensionInfo state and to detect and handle AccountSuspendedError during the authentication process.
packages/cli/src/ui/components/DialogManager.tsx
- Integrated the BannedAccountDialog into the DialogManager to ensure it is displayed when an account suspension is detected.
packages/cli/src/ui/contexts/UIActionsContext.tsx
- Extended the UIActions interface with a clearAccountSuspension method.
packages/cli/src/ui/contexts/UIStateContext.tsx
- Defined the AccountSuspensionInfo interface and added accountSuspensionInfo to the UIState interface.
packages/core/src/utils/errors.test.ts
- Added new test cases for toFriendlyError to verify correct identification and parsing of TOS_VIOLATION errors into AccountSuspendedError.
packages/core/src/utils/errors.ts
- Introduced the AccountSuspendedError class, updated toFriendlyError to specifically parse Google API errors for TOS_VIOLATION details, and added the isAccountSuspendedError utility function.

Activity

The pull request introduces a new feature for handling account suspension errors.
New UI components and error handling logic have been added.
Existing authentication and initialization flows have been updated to support the new error reporting mechanism.
Comprehensive unit tests have been added for the new UI component and updated for modified core logic.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces improved error handling for account suspension scenarios. It adds a new AccountSuspendedError type in the core package to specifically identify TOS violation errors from the API. This information is then propagated up to the CLI's UI layer, which now displays a BannedAccountDialog to the user. This dialog informs the user about the suspension and provides options to appeal, change authentication method, or exit. The changes are well-structured, with clear separation of concerns between the core error handling and the UI presentation. The implementation is robust, handling various states and edge cases, and is accompanied by thorough unit tests for the new components and logic. Overall, this is a solid feature implementation.

galz10 · 2026-02-27T18:38:50Z

/patch release

github-actions · 2026-02-27T18:39:12Z

✅ Patch workflow(s) dispatched successfully!

📋 Details:

Channels: stable,preview
Commit: ea48bd9414a0e1de735933211680dcced3731946
Workflows Created: 2

🔗 Track Progress:

Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com> # Conflicts: # packages/cli/src/test-utils/render.tsx # packages/cli/src/ui/AppContainer.tsx # packages/cli/src/ui/contexts/UIActionsContext.tsx # packages/core/src/utils/errors.test.ts # packages/core/src/utils/errors.ts

github-actions · 2026-02-27T18:41:23Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: stable → will publish to npm tag latest
Commit: ea48bd9414a0e1de735933211680dcced3731946
Hotfix Branch: hotfix/v0.30.1/0.30.2/stable/cherry-pick-ea48bd9/pr-20577
Hotfix PR: #20591
⚠️ Status: Cherry-pick conflicts detected - manual resolution required

📝 Next Steps:

⚠️ Resolve conflicts in the hotfix PR first: #20591
Test your changes after resolving conflicts
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #20591

Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com> # Conflicts: # packages/cli/src/test-utils/render.tsx # packages/cli/src/ui/AppContainer.tsx # packages/cli/src/ui/contexts/UIActionsContext.tsx

github-actions · 2026-02-27T18:41:28Z

🚀 Patch PR Created!

📋 Patch Details:

Environment: prod
Channel: preview → will publish to npm tag preview
Commit: ea48bd9414a0e1de735933211680dcced3731946
Hotfix Branch: hotfix/v0.31.0-preview.1/0.31.0-preview.2/preview/cherry-pick-ea48bd9/pr-20577
Hotfix PR: #20592
⚠️ Status: Cherry-pick conflicts detected - manual resolution required

📝 Next Steps:

⚠️ Resolve conflicts in the hotfix PR first: #20592
Test your changes after resolving conflicts
Once merged, the patch release will automatically trigger
You'll receive updates here when the release completes

🔗 Track Progress:

View hotfix PR #20592

github-actions · 2026-02-27T19:55:46Z

🚀 Patch Release Started!

📋 Release Details:

Environment: prod
Channel: preview → publishing to npm tag preview
Version: v0.31.0-preview.1
Hotfix PR: Merged ✅
Release Branch: release/v0.31.0-preview.1-pr-20577

⏳ Status: The patch release is now running. You'll receive another update when it completes.

🔗 Track Progress:

View release workflow

github-actions · 2026-02-27T20:46:43Z

✅ Patch Release Complete!

📦 Release Details:

Version: 0.31.0-preview.2
NPM Tag: preview
Channel: preview
Dry Run: false

🎉 Status: Your patch has been successfully released and published to npm!

📝 What's Available:

GitHub Release: View release v0.31.0-preview.2
NPM Package: npm install @google/gemini-cli@preview

🔗 Links:

Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>

gsquared94 requested a review from a team as a code owner February 27, 2026 16:58

galz10 approved these changes Feb 27, 2026

View reviewed changes

gemini-code-assist bot reviewed Feb 27, 2026

View reviewed changes

gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Feb 27, 2026

gsquared94 enabled auto-merge February 27, 2026 17:52

gsquared94 force-pushed the better-error-messages branch from 1ac3072 to da02732 Compare February 27, 2026 17:52

feat: better error messages

2c0589e

gsquared94 force-pushed the better-error-messages branch from da02732 to 2c0589e Compare February 27, 2026 18:00

Merge branch 'main' into better-error-messages

3e186c1

gsquared94 added this pull request to the merge queue Feb 27, 2026

Merged via the queue into google-gemini:main with commit ea48bd9 Feb 27, 2026
27 checks passed

gsquared94 deleted the better-error-messages branch February 27, 2026 18:33

gemini-code-assist bot mentioned this pull request Feb 27, 2026

Changelog for v0.32.0-preview.0 #20627

Merged

BryanBradfo pushed a commit to BryanBradfo/gemini-cli that referenced this pull request Mar 5, 2026

feat: better error messages (google-gemini#20577)

e048e72

Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>

liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026

feat: better error messages (google-gemini#20577)

69f58b7

Co-authored-by: Gal Zahavi <38544478+galz10@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: better error messages#20577

feat: better error messages#20577
gsquared94 merged 2 commits intogoogle-gemini:mainfrom
gsquared94:better-error-messages

gsquared94 commented Feb 27, 2026

Uh oh!

gemini-code-assist bot commented Feb 27, 2026

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

galz10 commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gsquared94 commented Feb 27, 2026

Uh oh!

gemini-code-assist bot commented Feb 27, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

galz10 commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants