Skip to content

Code review fixes as a pr#20612

Merged
jacob314 merged 3 commits intomainfrom
pr_20399_feedback
Mar 3, 2026
Merged

Code review fixes as a pr#20612
jacob314 merged 3 commits intomainfrom
pr_20399_feedback

Conversation

@jacob314
Copy link
Contributor

Summary

Fixes issue #20600

@jacob314 jacob314 requested a review from a team as a code owner February 27, 2026 21:06
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Feb 27, 2026

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface's error reporting and debugging hints. It ensures that critical debugging information, such as the F12 hotkey hint and error summaries, is more consistently available, especially in development environments. Additionally, it improves user guidance for adjusting error verbosity settings, making the CLI more intuitive for both end-users and developers.

Highlights

  • F12 Hint Visibility: The F12 hint for the debug console is now consistently displayed, irrespective of the error verbosity setting, ensuring users always know how to close it.
  • Error Summary in Development Mode: Error summaries in the footer are now visible in low verbosity mode when the application is running in development mode, providing more debugging context to developers.
  • Improved Error Verbosity Guidance: Error messages related to stream processing have been updated to provide clearer instructions on how to access full error details via the /settings command, improving user experience.
  • Required Error Verbosity Prop: The errorVerbosity prop in useLoadingIndicator has been made a required parameter, ensuring explicit handling of error display settings.
Changelog
  • packages/cli/src/ui/components/DetailedMessagesDisplay.test.tsx
    • Updated test description and assertion to reflect that the F12 hint is always shown.
  • packages/cli/src/ui/components/DetailedMessagesDisplay.tsx
    • Removed imports for useConfig and useSettings.
    • Removed logic that conditionally displayed the F12 hint based on error verbosity or debug mode.
    • Modified the Debug Console text to always include the (F12 to close) hint.
  • packages/cli/src/ui/components/Footer.test.tsx
    • Added mocking for the isDevelopment utility.
    • Introduced beforeEach and afterEach hooks to manage mockIsDevelopment state.
    • Added a new test case to verify that the error summary is shown in low verbosity mode when isDevelopment is true.
    • Updated the description of an existing test case for clarity.
  • packages/cli/src/ui/components/Footer.tsx
    • Modified the showErrorSummary condition to include isDevelopment as a factor for displaying the error summary.
  • packages/cli/src/ui/hooks/useGeminiStream.ts
    • Updated SUPPRESSED_TOOL_ERRORS_NOTE and LOW_VERBOSITY_FAILURE_NOTE messages to instruct users to use the /settings command to change "Error Verbosity" instead of directly mentioning ui.errorVerbosity.
  • packages/cli/src/ui/hooks/useLoadingIndicator.test.tsx
    • Changed the errorVerbosity property in the UseLoadingIndicatorProps type definition to be required.
  • packages/cli/src/ui/hooks/useLoadingIndicator.ts
    • Changed the errorVerbosity property in the UseLoadingIndicatorProps interface to be required.
    • Removed the default value assignment for errorVerbosity in the useLoadingIndicator function parameters.
Activity
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.


const SUPPRESSED_TOOL_ERRORS_NOTE =
'Some internal tool attempts failed before this final error. Press F12 for diagnostics, or set ui.errorVerbosity to full for full details.';
'Some internal tool attempts failed before this final error. Press F12 for diagnostics, or run /settings and change "Error Verbosity" to full for details.';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweaked as I don't think average users know how to set ui.errorVerbosity

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several fixes and improvements across the UI components and hooks. The debug console now consistently shows the F12 hotkey hint, and the footer component displays the error summary in development mode for better developer experience. User-facing messages have been clarified, and the useLoadingIndicator hook was refactored to improve type safety by making the errorVerbosity prop mandatory. The changes are well-tested and correctly implement the intended fixes. I have not found any issues of high or critical severity.

@github-actions
Copy link

github-actions bot commented Feb 27, 2026

Size Change: -151 B (0%)

Total Size: 25.8 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.3 MB -151 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the area/core Issues related to User Interface, OS Support, Core Functionality label Feb 27, 2026
@jacob314 jacob314 enabled auto-merge March 2, 2026 17:32
@jacob314 jacob314 added this pull request to the merge queue Mar 3, 2026
Merged via the queue into main with commit 8303edb Mar 3, 2026
27 checks passed
@jacob314 jacob314 deleted the pr_20399_feedback branch March 3, 2026 04:45
BryanBradfo pushed a commit to BryanBradfo/gemini-cli that referenced this pull request Mar 5, 2026
struckoff pushed a commit to struckoff/gemini-cli that referenced this pull request Mar 6, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants