fix(docs): update theme screenshots and add missing themes#20689
fix(docs): update theme screenshots and add missing themes#20689diodesign merged 11 commits intogoogle-gemini:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for CLI themes by ensuring its accuracy and completeness. It introduces two new built-in themes, updates all existing theme screenshots to reflect the current user interface, and addresses missing image asset references, providing a more current and comprehensive guide for users. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the theme documentation in docs/cli/themes.md. It adds entries and screenshots for the 'Holiday' and 'Shades Of Purple' themes. It also updates the image paths for several existing themes and corrects the heading for the 'Atom One' theme to be consistent with its definition. The changes are confined to documentation and appear to correctly reflect the available themes.
|
After this is merged, the new and updated PNGs need to be uploaded to the site. I can do that and aiming to automate. |
Updated image paths in themes documentation to use the '/docs' prefix for consistency.
|
This should ideally be merged after the site-side code is updated to automatically load images from the Gemini CLI repo into the website Edit: That site-side update is now merged, so this is good to go. |
ec7773e
|
This also fixed #19423 - thank you. |
…mini#20689) Co-authored-by: Chris Williams <chrisjwilliams@google.com> Co-authored-by: Chris Williams <diodesign@gmail.com> Co-authored-by: Sam Roberts <158088236+g-samroberts@users.noreply.github.com>
…mini#20689) Co-authored-by: Chris Williams <chrisjwilliams@google.com> Co-authored-by: Chris Williams <diodesign@gmail.com> Co-authored-by: Sam Roberts <158088236+g-samroberts@users.noreply.github.com>
Co-authored-by: Chris Williams <chrisjwilliams@google.com> Co-authored-by: Chris Williams <diodesign@gmail.com> Co-authored-by: Sam Roberts <158088236+g-samroberts@users.noreply.github.com>
…mini#20689) Co-authored-by: Chris Williams <chrisjwilliams@google.com> Co-authored-by: Chris Williams <diodesign@gmail.com> Co-authored-by: Sam Roberts <158088236+g-samroberts@users.noreply.github.com>
Summary
Note on image paths
Image paths use
/assets/...which does not render in the raw markdown on GitHub. Relative paths(
../assets/...) would fix that, but the previous version used absolute paths I assume because the external docs sitebuild resolves them differently. So I kept path format as-is.
Related Issues
Closes #20688
Pre-Merge Checklist