feat(admin): enable 30 day default retention for chat history & remove warning #20853
feat(admin): enable 30 day default retention for chat history & remove warning #20853
Conversation
|
Hi @skeshive, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request simplifies the chat history retention policy by establishing a default 30-day retention period and automatically enabling session cleanup. It removes the need for users to acknowledge a warning or manually enable this feature, integrating it seamlessly into the application's default behavior. The changes primarily involve updating configuration settings and removing UI elements and logic related to the old warning system. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully implements the feature to enable a 30-day default retention for chat history and removes the associated warning mechanism. The changes are consistent across the settings interface, schema, UI components, and related hooks and tests. The removal of the warningAcknowledged property and the SessionRetentionWarningDialog component, along with setting general.sessionRetention.enabled to true and general.sessionRetention.maxAge to '30d' by default, aligns perfectly with the stated objective. The code is clean and well-structured, with all deprecated components and logic being appropriately removed.
|
Size Change: -6.53 kB (-0.03%) Total Size: 25.8 MB
ℹ️ View Unchanged
|
Updates both automatic session retention and manual session deletion to purge the entire session-specific directory (~/.gemini/tmp/<project>/<sessionId>/). This ensures that implementation plans, tasks, and other session-specific artifacts are cleaned up along with the session file. - Update cleanupExpiredSessions to delete session directories. - Update ChatRecordingService.deleteSession to purge directories and logs. - Add regression tests for directory cleanup. - Update documentation to clarify plan/task cleanup behavior. - Document session retention defaults (30 days) and configuration as a follow up to #20853. - Clarify that manual deletion also removes plans and tasks. Fixes #17793 This update follows up on the session retention implementation in #20853
Updates both automatic session retention and manual session deletion to purge the entire session-specific directory (~/.gemini/tmp/<project>/<sessionId>/). This ensures that implementation plans, tasks, and other session-specific artifacts are cleaned up along with the session file. - Update cleanupExpiredSessions to delete session directories. - Update ChatRecordingService.deleteSession to purge directories and logs. - Add regression tests for directory cleanup. - Update documentation to clarify plan/task cleanup behavior. - Document session retention defaults (30 days) and configuration as a follow up to #20853. - Clarify that manual deletion also removes plans and tasks. Fixes #17793 This update follows up on the session retention implementation in #20853
## 原因 Gemini CLI が過去のバージョンでセッション保持警告の確認フラグとして warningAcknowledged を設定ファイルに書き込んでいた。 PR google-gemini/gemini-cli#20853 でその警告機能ごと削除されたが、 dotfiles に書き込まれたフィールドがそのまま残っていた。 公式スキーマの sessionRetention には warningAcknowledged が定義されておらず、 additionalProperties: false のため CI バリデーションが失敗していた。 ## 対策 - dot_gemini/settings.json: warningAcknowledged フィールドを削除 - tests/syntax/test_json_schema.sh: general セクション以下の additionalProperties 制約を再帰的に除去するよう修正 (Gemini CLI 書き込みフィールドをネストした階層も許容するため) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* feat: PR ヘルスモニターを追加する - skills/pr-workflow/pr-health-monitor.md を追加 - PR 作成後の CI 確認・Copilot 待機・コードレビュー・コンフリクト確認・PR 本文更新を Task で並列実行するスキル - commands/handle-pr-reviews.md を追加 - Copilot レビュー検出時に自動実行されるコマンド - 全未解決スレッドを取得しコード修正・返信・resolve・CI 確認を体系的に処理する - wait-for-copilot-review.sh の tmux 通知をコマンド形式に変更 - 成功時: 自然言語の代わりに `/handle-pr-reviews URL` を tmux に送信 - Claude Code がコマンドを受け取り自動で対応できるようにする - タイムアウト時は手動確認を促す自然言語のまま維持 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: wait-for-copilot-review.sh の実行権限を修正する chezmoi re-add により executable_ プレフィックス付きにリネームし、 ファイルに実行権限(chmod +x)を付与する Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: Gemini CLI settings.json の CI バリデーションエラーを修正する ## 原因 Gemini CLI が過去のバージョンでセッション保持警告の確認フラグとして warningAcknowledged を設定ファイルに書き込んでいた。 PR google-gemini/gemini-cli#20853 でその警告機能ごと削除されたが、 dotfiles に書き込まれたフィールドがそのまま残っていた。 公式スキーマの sessionRetention には warningAcknowledged が定義されておらず、 additionalProperties: false のため CI バリデーションが失敗していた。 ## 対策 - dot_gemini/settings.json: warningAcknowledged フィールドを削除 - tests/syntax/test_json_schema.sh: general セクション以下の additionalProperties 制約を再帰的に除去するよう修正 (Gemini CLI 書き込みフィールドをネストした階層も許容するため) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix: Copilot レビューコメントへの対応 - `CI確認` を `CI 確認`、`PR作成後` を `PR 作成後`、`Copilotレビュー` を `Copilot レビュー` に修正(日本語・英数字間のスペースルール) - `.comments.nodes[0]` を `.comments.nodes | last` に変更し、最新コメントを参照するよう修正 - `reviewThreads(first: 100)` の上限とページネーション必要性をコメントで明記 - `pr-health-monitor.md` の Step 0 URL パース例を `grep -oP` キャプチャグループ方式から個別抽出方式に修正 - `<PR番号またはURL>` を `<PR 番号または URL>` に修正 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: akubiusa <222856114+akubiusa@users.noreply.github.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Related Issues
https://github.com/google-gemini/maintainers-gemini-cli/issues/1194