Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the user interface experience and addressing a critical rendering bug. It introduces a conditional logo display to ensure visual integrity across different terminal environments, specifically Mac Terminal, and refactors user identity logic to guarantee immediate display of user information upon login, enhancing responsiveness and user feedback. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Thank you for linking an issue! This pull request has been automatically reopened. |
|
Size Change: +166 B (0%) Total Size: 26.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for rendering the CLI logo correctly in Apple Terminal by conditionally displaying a symmetric icon. It also resolves a regression where the user's email was not immediately visible at login by refactoring the UserIdentity component to use useMemo instead of useEffect for fetching the cached Google account. New snapshot tests have been added for the AppHeader icon rendering, and StatusDisplay tests have been updated to align with the recommended vi.stubEnv and vi.unstubAllEnvs pattern for environment variables. The changes are well-implemented and directly address the stated objectives.
Note: Security Review is unavailable for this PR.
6ba058c to
1e0643b
Compare
… because it is not visible until after the component is rendered to static.
1e0643b to
f12d348
Compare
Updated mac terminal logo

Leave logo the same on other terminals and fix issue showing username due to static content.

Revert change to use useEffect breaking showing the username at login because it is not visible until after the component is rendered to static.
Fixes #20924