Skip to content

feat/redesign header compact#20922

Merged
jacob314 merged 4 commits intomainfrom
feat/redesign-header-compact
Mar 9, 2026
Merged

feat/redesign header compact#20922
jacob314 merged 4 commits intomainfrom
feat/redesign-header-compact

Conversation

@jacob314
Copy link
Contributor

@jacob314 jacob314 commented Mar 3, 2026

  • Tweak the logo to look ok in the Mac Terminal

Updated mac terminal logo
Screenshot 2026-03-02 at 2 33 03 PM

Leave logo the same on other terminals and fix issue showing username due to static content.
image

Revert change to use useEffect breaking showing the username at login because it is not visible until after the component is rendered to static.

Fixes #20924

@jacob314 jacob314 requested a review from a team as a code owner March 3, 2026 05:29
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 3, 2026

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the user interface experience and addressing a critical rendering bug. It introduces a conditional logo display to ensure visual integrity across different terminal environments, specifically Mac Terminal, and refactors user identity logic to guarantee immediate display of user information upon login, enhancing responsiveness and user feedback.

Highlights

  • Mac Terminal Logo Tweak: The CLI logo has been adjusted to display correctly within the Mac Terminal, addressing visual inconsistencies caused by line-height padding.
  • User Identity Rendering Fix: A regression where the username was not visible at login until after the component rendered statically has been resolved by reverting the use of useEffect for email retrieval.
Changelog
  • packages/cli/src/ui/components/AppHeader.tsx
    • Implemented conditional rendering for the CLI logo, displaying a MAC_TERMINAL_ICON when isAppleTerminal is true and DEFAULT_ICON otherwise.
    • Imported isAppleTerminal utility from @google/gemini-cli-core.
  • packages/cli/src/ui/components/AppHeaderIcon.test.tsx
    • Added a new test file to verify the correct rendering of the AppHeader icon.
    • Included tests to assert that the default icon is rendered in standard terminals and the symmetric icon is rendered in Apple Terminal.
    • Mocked the isAppleTerminal function to control test scenarios.
  • packages/cli/src/ui/components/StatusDisplay.test.tsx
    • Refactored environment variable handling in tests to use vi.stubEnv and vi.unstubAllEnvs for improved test isolation and cleanup.
    • Moved GEMINI_SYSTEM_MD environment variable initialization to a beforeEach hook.
  • packages/cli/src/ui/components/UserIdentity.test.tsx
    • Added a regression test to confirm that the user's email is rendered on the very first frame, preventing a previous rendering delay.
  • packages/cli/src/ui/components/UserIdentity.tsx
    • Refactored the email retrieval logic from useState and useEffect to useMemo to ensure synchronous availability of the user's email.
    • Removed unused useEffect and useState imports.
  • packages/cli/src/ui/components/snapshots/AppHeaderIcon-AppHeader-Icon-Rendering-renders-the-default-icon-in-standard-terminals.snap.svg
    • Added SVG snapshot for the default header icon rendering.
  • packages/cli/src/ui/components/snapshots/AppHeaderIcon-AppHeader-Icon-Rendering-renders-the-symmetric-icon-in-Apple-Terminal.snap.svg
    • Added SVG snapshot for the Apple Terminal specific header icon rendering.
  • packages/cli/src/ui/components/snapshots/AppHeaderIcon.test.tsx.snap
    • Added Vitest snapshot for AppHeaderIcon.test.tsx.
Activity
  • No specific activity (comments, reviews, progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 3, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Mar 3, 2026
@gemini-cli gemini-cli bot reopened this Mar 3, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 3, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@jacob314 jacob314 enabled auto-merge March 3, 2026 05:41
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Size Change: +166 B (0%)

Total Size: 26.1 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.7 MB +166 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a fix for rendering the CLI logo correctly in Apple Terminal by conditionally displaying a symmetric icon. It also resolves a regression where the user's email was not immediately visible at login by refactoring the UserIdentity component to use useMemo instead of useEffect for fetching the cached Google account. New snapshot tests have been added for the AppHeader icon rendering, and StatusDisplay tests have been updated to align with the recommended vi.stubEnv and vi.unstubAllEnvs pattern for environment variables. The changes are well-implemented and directly address the stated objectives.

Note: Security Review is unavailable for this PR.

@jacob314 jacob314 added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
@jacob314 jacob314 added this pull request to the merge queue Mar 3, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 3, 2026
@jacob314 jacob314 force-pushed the feat/redesign-header-compact branch from 6ba058c to 1e0643b Compare March 9, 2026 17:10
@jacob314 jacob314 enabled auto-merge March 9, 2026 17:11
@jacob314 jacob314 force-pushed the feat/redesign-header-compact branch from 1e0643b to f12d348 Compare March 9, 2026 20:20
@jacob314 jacob314 added this pull request to the merge queue Mar 9, 2026
Merged via the queue into main with commit e406dcc Mar 9, 2026
27 checks passed
@jacob314 jacob314 deleted the feat/redesign-header-compact branch March 9, 2026 20:55
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
DavidAPierce pushed a commit that referenced this pull request Mar 16, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Header Redesign Code Review comment fixes

2 participants