feat(agents): directly indicate auth required state#20986
Conversation
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by providing clear and consistent feedback when an agent requires authorization. It introduces a standardized message that is automatically appended to the agent's output, ensuring that users are always aware of the authorization status, regardless of the agent's specific response. This change improves clarity and reduces potential confusion during agent interactions. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request effectively ensures that users are notified when an agent requires authorization by adding a standard message. The implementation is clean and includes good test coverage. However, I've identified a race condition that could lead to duplicate messages under certain circumstances. By reordering two method calls, this issue can be easily resolved, making the new feature more robust. My review includes specific suggestions to address this.
|
Size Change: +536 B (0%) Total Size: 25.8 MB ℹ️ View Unchanged
|
863c467 to
69a81c7
Compare
abhipatel12
left a comment
There was a problem hiding this comment.
LGTM, one non-blocking nit
69a81c7 to
5a26a20
Compare
Summary
This PR updates the
A2AResultReassemblerto explicitly handle theauth-requiredstate by appending a standard instruction message (AUTH_REQUIRED_MSG) to the output. This ensures that users are clearly notified when an agent requires authorization, even if the agent's message itself is sparse.Details
AUTH_REQUIRED_MSGconstant toa2aUtils.ts.appendStateInstructionsinA2AResultReassemblerto append the auth message when the task state isauth-required.a2aUtils.test.ts.Related Issues
Fixes: #17606
How to Validate
Run the unit tests:
npm test -w @google/gemini-cli-core -- src/agents/a2aUtils.test.tsPre-Merge Checklist