Skip to content

feat(core): Disable fast ack helper for hints.#21011

Merged
joshualitt merged 1 commit intomainfrom
jl/disable-fast-ack-helper
Mar 4, 2026
Merged

feat(core): Disable fast ack helper for hints.#21011
joshualitt merged 1 commit intomainfrom
jl/disable-fast-ack-helper

Conversation

@joshualitt
Copy link
Contributor

@joshualitt joshualitt commented Mar 3, 2026

Fixes #21121

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 3, 2026

Hi @joshualitt, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 3, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Mar 3, 2026
@joshualitt joshualitt reopened this Mar 3, 2026
@joshualitt joshualitt force-pushed the jl/disable-fast-ack-helper branch from 31edd18 to 093bed5 Compare March 3, 2026 20:30
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Size Change: -557 B (0%)

Total Size: 25.9 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.5 MB -557 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@joshualitt joshualitt marked this pull request as ready for review March 3, 2026 21:39
@joshualitt joshualitt requested a review from a team as a code owner March 3, 2026 21:39
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the handling of steering hints by disabling the 'fast ack helper' functionality. Previously, the CLI would generate an immediate acknowledgment message upon receiving a hint. This change removes that explicit acknowledgment, aiming to create a more direct and less verbose interaction flow for users, allowing the model's response to serve as the primary confirmation of hint processing.

Highlights

  • Removed Fast Acknowledgment for Hints: The explicit 'ACK' message that was previously generated and displayed by the CLI when a steering hint was provided has been removed. This streamlines the user interface by eliminating a redundant acknowledgment.
  • Updated Test Suites: Integration and unit tests related to the fast acknowledgment message have been updated to reflect its removal, ensuring tests pass correctly without expecting the 'ACK' output.
  • Cleaned Up Codebase: The generateSteeringAckMessage utility function and its associated imports have been removed from AppContainer.tsx and useGeminiStream.ts, simplifying the codebase.
Changelog
  • packages/cli/src/integration-tests/modelSteering.test.tsx
    • Removed waitForOutput assertion that checked for the 'ACK' message.
  • packages/cli/src/test-utils/fixtures/steering.responses
    • Deleted a JSON entry representing the fast acknowledgment message from the steering responses fixture.
  • packages/cli/src/ui/AppContainer.tsx
    • Removed the import of generateSteeringAckMessage.
    • Eliminated the call to generateSteeringAckMessage within the useEffect hook.
  • packages/cli/src/ui/hooks/useGeminiStream.test.tsx
    • Removed an expect assertion that checked for the 'info' type acknowledgment message in the history.
  • packages/cli/src/ui/hooks/useGeminiStream.ts
    • Removed the import of generateSteeringAckMessage.
    • Eliminated the call to generateSteeringAckMessage and its associated addItem logic.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request disables the 'fast acknowledgment' feature for user-provided steering hints. The changes remove the extra LLM call that was made to generate an acknowledgment message, which improves efficiency by reducing latency and token usage. The logic for handling hints is updated in AppContainer.tsx and useGeminiStream.ts, and the corresponding tests and mock data are adjusted to reflect this change. The implementation is consistent and correctly removes the feature from the CLI.

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 3, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 4, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Mar 4, 2026
@joshualitt joshualitt reopened this Mar 4, 2026
@joshualitt joshualitt added area/core Issues related to User Interface, OS Support, Core Functionality area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality and removed status/need-issue Pull requests that need to have an associated issue. labels Mar 4, 2026
Copy link
Collaborator

@abhipatel12 abhipatel12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshualitt joshualitt added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit 4c85d14 Mar 4, 2026
52 checks passed
@joshualitt joshualitt deleted the jl/disable-fast-ack-helper branch March 4, 2026 21:15
struckoff pushed a commit to struckoff/gemini-cli that referenced this pull request Mar 6, 2026
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality area/core Issues related to User Interface, OS Support, Core Functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable fast ack helper

2 participants