fix: model persistence for all scenarios

[sripasg]

Summary

• ensure onModelChange is same model is selected once with persistence flag off and immediately again with persistence flag on.
• This is annoyance to the user and should be fixed.

TEST=config.test.ts new case added and also manual

Details

• In config.ts setModel function, the check if (this.model !== newModel || this._activeModel !== newModel) wrapped both the state update and the persistence logic (this.onModelChange). Since selecting the identical manual model string meant the state didn't change, the logic bypassed persistence saving when toggling from "Remember: false" to "Remember: true".

• Moved the this.onModelChange call to the outer level so that it always executes if !isTemporary is true, ensuring that even if the active model didn't change visually, the persistence logic is applied securely.

Related Issues

Fixes #19864

How to Validate

• Try to set model with the persist flag off via /model
• Do this again but toggle persist flag to on - this time.
• It should save the model for future sessions.

Pre-Merge Checklist

• [NA] Updated relevant documentation and README (if needed)
• [✅] Added/updated tests (if needed)
• [NA] Noted breaking changes (if any)
• [✅] Validated on required platforms/methods:
  • [✅] MacOS
    • [✅] npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where the model persistence mechanism failed to correctly save a model if it was first set temporarily and then subsequently marked for persistence without a change in the model's value. The fix ensures that the onModelChange callback is reliably triggered for persistence, improving the user experience by consistently saving model selections across sessions.

Highlights

• Model Persistence Logic: The onModelChange callback in the setModel function was not always triggered when persisting a model that was previously set as temporary, specifically if the model value itself did not change.
• setModel Method Update: The onModelChange call in config.ts was moved to ensure it always executes when !isTemporary is true, regardless of whether the active model visually changed.
• New Test Case: A new test case was added to config.test.ts to validate that onModelChange is correctly invoked when persisting a model that was previously temporary.

Changelog

• packages/core/src/config/config.test.ts
  • Added a new test case to verify onModelChange is called when persisting a previously temporary model.
• packages/core/src/config/config.ts
  • Refactored the setModel method to ensure onModelChange is invoked for persistence even if the model value remains the same.

Activity

• Fixed issue [BUG] Manual model selection with "Remember model" enabled fails to persist on restart #19864.
• Added a new test case to config.test.ts to cover the persistence scenario.
• Validated the changes on MacOS using npm run.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a bug where model persistence was not triggered when selecting the same model again with the 'Remember' option enabled. The fix properly decouples the persistence logic (onModelChange) from the internal state update logic, ensuring that the persistence callback is always invoked when a model selection is not temporary. The addition of a specific test case for this scenario in config.test.ts is excellent and ensures this behavior is covered against future regressions. The changes are logical and well-implemented.

[github-actions]

Size Change: -8 B (0%)

Total Size: 25.9 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.5 MB	-8 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}