fix(ui): suppress redundant failure note when tool error note is shown

[NTaylorMullen]

Summary

Consolidate error diagnostic notes in the UI to avoid redundancy when both internal tool failures and final request failures occur simultaneously.

Existing failure:

Details

In low verbosity mode, the UI previously showed two identical "Press F12 for diagnostics" notes if a tool failed before the final request failure. This change suppresses the generic "This request failed..." note if the more specific "Some internal tool attempts failed..." note is already shown, as both provide the same diagnostic advice.

Related Issues

N/A

How to Validate

1. Trigger a scenario where a tool fails (e.g., a STOP_EXECUTION error) in low verbosity mode.
2. Observe that only one diagnostic note is shown instead of two.
3. Run npm test -w @google/gemini-cli -- src/ui/hooks/useGeminiStream.test.tsx to verify the fix.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the user interface's error reporting mechanism by eliminating redundant diagnostic messages. It ensures that users in low verbosity mode receive a single, clear error note when a tool failure precedes a final request failure, thereby improving the clarity and conciseness of error feedback.

Highlights

• UI Error Consolidation: Consolidated error diagnostic notes in the UI to prevent redundancy when both internal tool failures and final request failures occur simultaneously.
• Suppressed Redundant Note: The generic "This request failed..." note is now suppressed if the more specific "Some internal tool attempts failed..." note is already displayed, avoiding duplicate diagnostic advice in low verbosity mode.
• Test Update: Updated an existing test case to assert that the generic failure hint is no longer present when the suppressed tool error note is shown.

Changelog

• packages/cli/src/ui/hooks/useGeminiStream.test.tsx
  • Modified an assertion to expect the absence of a generic failure hint when a specific tool error note is displayed.
• packages/cli/src/ui/hooks/useGeminiStream.ts
  • Updated the conditional logic for displaying low verbosity failure notes to also check if a suppressed tool error note has already been shown, preventing the display of redundant messages.

Activity

• No human activity (comments, reviews, etc.) has occurred on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: +41 B (0%)

Total Size: 25.9 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.5 MB	+41 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request effectively resolves an issue with redundant UI error notes in low verbosity mode. The change to useGeminiStream.ts correctly suppresses the generic failure message when a more specific tool error note has already been displayed. The updated test in useGeminiStream.test.tsx accurately validates this new behavior. The implementation is clean and directly addresses the problem.

[jacob314]