Conversation
|
Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the code colorizer where ANSI escape codes present in the input code could "leak" and incorrectly color subsequent parts of the output. The changes introduce a mechanism to strip these escape codes before the code is highlighted and rendered, ensuring that only the intended syntax highlighting is applied. A new test case has been added to verify this fix. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a bug where ANSI escape codes were leaking colors into colorized code in the Gemini CLI. The changes include adding strip-ansi to remove these codes before highlighting and rendering the code, and a new test case to ensure that colors from ANSI escape codes do not leak into the colorized code, with a reminder for proper test cleanup using unmount.
| it('does not let colors from ansi escape codes leak into colorized code', async () => { | ||
| const code = 'line 1\n\x1b[41mline 2 with red background\x1b[0m\nline 3'; | ||
| const settings = new LoadedSettings( | ||
| { path: '', settings: {}, originalSettings: {} }, | ||
| { path: '', settings: {}, originalSettings: {} }, | ||
| { | ||
| path: '', | ||
| settings: { ui: { useAlternateBuffer: true, showLineNumbers: false } }, | ||
| originalSettings: { | ||
| ui: { useAlternateBuffer: true, showLineNumbers: false }, | ||
| }, | ||
| }, | ||
| { path: '', settings: {}, originalSettings: {} }, | ||
| true, | ||
| [], | ||
| ); | ||
|
|
||
| const result = colorizeCode({ | ||
| code, | ||
| language: 'javascript', | ||
| maxWidth: 80, | ||
| settings, | ||
| hideLineNumbers: true, | ||
| }); | ||
|
|
||
| const renderResult = renderWithProviders(<>{result}</>); | ||
| await renderResult.waitUntilReady(); | ||
|
|
||
| await expect(renderResult).toMatchSvgSnapshot(); | ||
| renderResult.unmount(); | ||
| }); |
There was a problem hiding this comment.
This test case verifies that ANSI escape codes do not leak colors into the colorized code. It uses a snapshot test to compare the rendered output with a pre-defined snapshot. Ensure that the snapshot is updated whenever the rendering logic changes. Additionally, when using renderWithProviders, the returned unmount function must be called at the end of the test for proper cleanup.
it('does not let colors from ansi escape codes leak into colorized code', async () => {
const code = 'line 1\n\x1b[41mline 2 with red background\x1b[0m\nline 3';
const settings = new LoadedSettings(
{ path: '', settings: {}, originalSettings: {} },
{ path: '', settings: {}, originalSettings: {} },
{
path: '',
settings: { ui: { useAlternateBuffer: true, showLineNumbers: false } },
originalSettings: {
ui: { useAlternateBuffer: true, showLineNumbers: false },
},
},
{ path: '', settings: {}, originalSettings: {} },
true,
[],
);
const result = colorizeCode({
code,
language: 'javascript',
maxWidth: 80,
settings,
hideLineNumbers: true,
});
const renderResult = renderWithProviders(<>{
result
}</>);
await renderResult.waitUntilReady();
await expect(renderResult).toMatchSvgSnapshot();
renderResult.unmount();
});
References
- When using
renderWithProvidersin tests, the returnedunmountfunction must be called at the end of the test to ensure proper cleanup and prevent resource leaks.
|
Size Change: +153 B (0%) Total Size: 26 MB ℹ️ View Unchanged
|
gemini-cli
bot
added
area/core
2 participants
Summary
Fixes #21320
Done by Gemini with TDD. Before these fixes the background color would be red for the colorized code.