Skip to content

fix: logic for task tracker strategy and remove tracker tools#21355

Merged
anj-s merged 2 commits intomainfrom
u/anj/fix-bad-merge-tracker
Mar 6, 2026
Merged

fix: logic for task tracker strategy and remove tracker tools#21355
anj-s merged 2 commits intomainfrom
u/anj/fix-bad-merge-tracker

Conversation

@anj-s
Copy link
Contributor

@anj-s anj-s commented Mar 6, 2026

Summary

Fixes a logic issue in snippets.ts where the task tracker strategy was shadowed, and removes tracker tools from tool-names.ts.

Files Changed

  • packages/core/src/prompts/snippets.ts
  • packages/core/src/tools/tool-names.ts

Related Issues

Fixes #21357

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 6, 2026

Hi @anj-s, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@github-actions
Copy link

github-actions bot commented Mar 6, 2026

Size Change: -221 B (0%)

Total Size: 26 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.5 MB -221 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 6, 2026

Hi there! Thank you for your contribution to Gemini CLI.

To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md.

This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding Fixes #123 or Related to #123), it will be automatically reopened.

How to link an issue:
Add a keyword followed by the issue number (e.g., Fixes #123) in the description of your pull request. For more details on supported keywords and how linking works, please refer to the GitHub Documentation on linking pull requests to issues.

Thank you for your understanding and for being a part of our community!

@gemini-cli gemini-cli bot closed this Mar 6, 2026
@anj-s anj-s changed the title fix merfge fix: logic for task tracker strategy and remove tracker tools Mar 6, 2026
@gemini-cli gemini-cli bot reopened this Mar 6, 2026
@gemini-cli
Copy link
Contributor

gemini-cli bot commented Mar 6, 2026

Thank you for linking an issue! This pull request has been automatically reopened.

@anj-s anj-s marked this pull request as ready for review March 6, 2026 03:24
@anj-s anj-s requested a review from jerop March 6, 2026 03:24
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a logical flaw in how workflow strategies are determined, ensuring that the task tracker strategy is correctly applied when an approved plan is available alongside task tracking capabilities. Concurrently, it cleans up the codebase by removing deprecated or unused task tracker tool definitions, streamlining the list of built-in tools.

Highlights

  • Logic Fix: The conditional logic within the workflowStepStrategy function in snippets.ts was reordered to correctly prioritize the scenario where both an approvedPlan and taskTracker are present. Previously, the approvedPlan condition alone would shadow the more specific approvedPlan && taskTracker condition.
  • Tool Removal: Several TRACKER_ prefixed tool names, including TRACKER_CREATE_TASK_TOOL_NAME, TRACKER_UPDATE_TASK_TOOL_NAME, TRACKER_GET_TASK_TOOL_NAME, TRACKER_LIST_TASKS_TOOL_NAME, TRACKER_ADD_DEPENDENCY_TOOL_NAME, and TRACKER_VISUALIZE_TOOL_NAME, were removed from the ALL_BUILTIN_TOOL_NAMES array in tool-names.ts.
Changelog
  • packages/core/src/prompts/snippets.ts
    • Reordered if conditions in workflowStepStrategy to ensure options.approvedPlan && options.taskTracker is evaluated before options.approvedPlan.
  • packages/core/src/tools/tool-names.ts
    • Removed six TRACKER_ prefixed tool names from ALL_BUILTIN_TOOL_NAMES.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a logic issue in workflowStepStrategy where a condition was being shadowed, ensuring the task tracker-specific prompt is used when appropriate. It also removes the tracker tools from the list of all built-in tools, which appears to be part of making them optional.

My review includes a suggestion to refactor the updated logic in snippets.ts to reduce code duplication in the returned prompt strings. This will improve long-term maintainability.

@gemini-cli gemini-cli bot added the area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality label Mar 6, 2026
@anj-s anj-s added this pull request to the merge queue Mar 6, 2026
Merged via the queue into main with commit c1317aa Mar 6, 2026
27 checks passed
@anj-s anj-s deleted the u/anj/fix-bad-merge-tracker branch March 6, 2026 15:33
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix unreachable task tracker strategy and clean up tool names

2 participants