Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 49 additions & 0 deletions packages/cli/src/utils/settingsUtils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -734,6 +734,55 @@ describe('SettingsUtils', () => {
);
expect(result).toBe('false');
});

it('should display objects as JSON strings, not "[object Object]"', () => {
vi.mocked(getSettingsSchema).mockReturnValue({
experimental: {
type: 'object',
label: 'Experimental',
category: 'Experimental',
requiresRestart: true,
default: {},
description: 'Experimental settings',
showInDialog: false,
properties: {
gemmaModelRouter: {
type: 'object',
label: 'Gemma Model Router',
category: 'Experimental',
requiresRestart: true,
default: {},
description: 'Gemma model router settings',
showInDialog: true,
},
},
},
} as unknown as SettingsSchemaType);

// Test with empty object (default)
const emptySettings = makeMockSettings({});
const emptyResult = getDisplayValue(
'experimental.gemmaModelRouter',
emptySettings,
emptySettings,
);
expect(emptyResult).toBe('{}');
expect(emptyResult).not.toBe('[object Object]');

// Test with object containing values
const settings = makeMockSettings({
experimental: {
gemmaModelRouter: { enabled: true, host: 'localhost' },
},
});
const result = getDisplayValue(
'experimental.gemmaModelRouter',
settings,
settings,
);
expect(result).toBe('{"enabled":true,"host":"localhost"}*');
expect(result).not.toContain('[object Object]');
});
});

describe('getDisplayValue with units', () => {
Expand Down
9 changes: 8 additions & 1 deletion packages/cli/src/utils/settingsUtils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,14 @@ export function getDisplayValue(

let valueString = String(value);

if (definition?.type === 'enum' && definition.options) {
// Handle object types by stringifying them
if (
definition?.type === 'object' &&
value !== null &&
typeof value === 'object'
) {
valueString = JSON.stringify(value);
} else if (definition?.type === 'enum' && definition.options) {
const option = definition.options?.find((option) => option.value === value);
valueString = option?.label ?? `${value}`;
}
Expand Down
Loading