Make test suite pass when the GEMINI_SYSTEM_MD env variable or GEMINI_WRITE_SYSTEM_MD variable happens to be set locally/

[jacob314]

Summary

I've been running with a custom GEMINI_SYSTEM_MD and noticed a few spurious test failures. Fixed the glitch.

Fixes #21482

[gemini-cli]

Hi @jacob314, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where local environment variable settings for GEMINI_SYSTEM_MD and GEMINI_WRITE_SYSTEM_MD could lead to inconsistent and failing test runs. The changes ensure that the test suite executes reliably regardless of the developer's local environment configuration, thereby improving test stability and developer experience.

Highlights

• Test Suite Stability: Introduced beforeEach and afterEach hooks in relevant test files to ensure environment variables GEMINI_SYSTEM_MD and GEMINI_WRITE_SYSTEM_MD do not interfere with test execution.
• Environment Variable Handling: Utilized vi.stubEnv to clear the specified environment variables before each test and vi.unstubAllEnvs to restore the environment after each test, preventing local configurations from causing spurious failures.

Changelog

• packages/core/src/agents/generalist-agent.test.ts
  • Added beforeEach and afterEach hooks to manage environment variables.
  • Stubbed GEMINI_SYSTEM_MD and GEMINI_WRITE_SYSTEM_MD to empty strings before each test.
  • Unstubbed all environment variables after each test.
• packages/core/src/prompts/promptProvider.test.ts
  • Imported afterEach from vitest.
  • Added vi.stubEnv calls within beforeEach to clear GEMINI_SYSTEM_MD and GEMINI_WRITE_SYSTEM_MD.
  • Added an afterEach hook to unstub all environment variables.

Activity

• No human activity has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request improves the reliability of the test suite by isolating tests from local environment configurations. The changes correctly stub the GEMINI_SYSTEM_MD and GEMINI_WRITE_SYSTEM_MD environment variables before each test run and restore them afterward, following the project's testing conventions. This prevents local developer settings from causing spurious test failures.

[github-actions]

Size Change: -4 B (0%)

Total Size: 26 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	25.5 MB	-4 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}