Feat/task tree step through#21616
Conversation
Adds additional commonly encountered binary file extensions to BINARY_FILE_PATTERNS and MEDIA_FILE_PATTERNS to prevent binary files from being processed as text. Also alphabetizes both arrays.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces significant enhancements to the CLI's interactive capabilities, providing users with unprecedented control and visibility over agent execution. By implementing a step-through approval mode and a hierarchical task tree visualization, the system now allows for detailed inspection and interactive management of complex, multi-step operations, fostering greater trust and facilitating debugging of agentic workflows. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces significant new features for monitoring and controlling agent execution: an interactive task tree for visualizing tool calls and a step-through approval mode. The implementation across the core scheduler and UI components appears well-structured. My main concern is the inclusion of temporary build error logs (errors-cli-8.txt and packages/a2a-server/errors8.txt) in the commit history, which should be removed.
| @@ -0,0 +1,6 @@ | |||
| src/ui/components/Composer.tsx(133,62): error TS2339: Property 'info' does not exist on type '{ error: string; success: string; warning: string; }'. | |||
| @@ -0,0 +1,74 @@ | |||
| src/agent/task.ts(30,8): error TS2305: Module '"@google/gemini-cli-core"' has no exported member 'ToolLiveOutput'. | |||
|
Hey @Khushi281300 , I appreciate your efforts, but your PR creates a lot of redundant work that feels like you just copied and pasted my project spec into an agent and hoped for the best. I'd also argue that the task tree visualization is a lot more complicated than just wrapping the existing There's a lot of issues with your implementation, here are a few:
|
|
because #21484 was not assigned (b/c it hasn't been labeled "help wanted") it's technically OK for you to open this PR...but we need to ask ourselves if it was worth it. the more times engineers have to "play referee", the less they're going to love being open source. let's regulate ourselves a bit here guys...let's have some respect and love for the repository... @Khushi281300 unless you feel like there is a good reason for this PR to compete with the ones @TravisHaa opened, the most respectful thing you could do is just close this. I know it can be hard to land changes right now because all of the help wanted issues are already taken. there are three paths to landing PRs as an external contributor...
I hope that my advice helps you land changes. its not a smooth and easy path but we can make it better for each other. |
queued → pending → running → success | error | cancelled
Related Issues
Closes #21484
How to Validate
Enable STEP mode.
Run a command that triggers multiple tool calls, for example:
↑ / ↓moves focus across nodesEnterinteracts with the selected nodePre-Merge Checklist
Validated Platforms
Windows
MacOS
Linux