Skip to content

build(release): restrict npm bundling to non-stable tags#21821

Merged
sehoon38 merged 1 commit intomainfrom
build/restrict-npm-bundling
Mar 10, 2026
Merged

build(release): restrict npm bundling to non-stable tags#21821
sehoon38 merged 1 commit intomainfrom
build/restrict-npm-bundling

Conversation

@sehoon38
Copy link
Contributor

Summary

This PR restricts the new NPM release bundling step to pre-releases (preview, nightly, etc.) so that we can fully test the bundled CLI artifacts before applying this change to stable (latest) releases.

Details

The GitHub Action publish-release now explicitly excludes latest from running the prepare-npm-release.js bundling script. This ensures latest deployments remain unchanged for now.

Related Issues

Closes #21820

How to Validate

  • Confirm scripts/prepare-npm-release.js is not run during a stable release publish action.
  • Confirm it is run for a preview release action.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:

@sehoon38 sehoon38 requested a review from a team as a code owner March 10, 2026 04:00
@gemini-cli gemini-cli bot added the 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. label Mar 10, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a cautious rollout strategy for a new NPM release bundling process. By limiting the bundling step to pre-release channels, it enables comprehensive testing and validation of the bundled CLI artifacts in a controlled environment, thereby mitigating risks and ensuring the continued stability of current production deployments before the change is applied to stable releases.

Highlights

  • NPM Release Bundling Restriction: The new NPM release bundling step has been restricted to only run for pre-release tags (e.g., 'preview', 'nightly') and will explicitly not execute for 'latest' (stable) releases.
Changelog
  • .github/actions/publish-release/action.yml
    • Modified the conditional logic for the 'Prepare bundled CLI for npm release' step to prevent it from running when the 'npm-tag' input is 'latest'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Collaborator

@mattKorwel mattKorwel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Size Change: -4 B (0%)

Total Size: 26.1 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.7 MB -4 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the publish-release GitHub Action. It modifies the conditional execution of the 'Prepare bundled CLI for npm release' step, adding a check to ensure it does not run for releases tagged as latest. This change aligns with the goal of running the bundling process only for pre-releases.

@sehoon38 sehoon38 enabled auto-merge March 10, 2026 04:17
@sehoon38 sehoon38 added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit c25ff94 Mar 10, 2026
30 checks passed
@sehoon38 sehoon38 deleted the build/restrict-npm-bundling branch March 10, 2026 04:28
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test NPM release bundling on preview and nightly before stable

2 participants