build(release): restrict npm bundling to non-stable tags#21821
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a cautious rollout strategy for a new NPM release bundling process. By limiting the bundling step to pre-release channels, it enables comprehensive testing and validation of the bundled CLI artifacts in a controlled environment, thereby mitigating risks and ensuring the continued stability of current production deployments before the change is applied to stable releases. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: -4 B (0%) Total Size: 26.1 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request updates the publish-release GitHub Action. It modifies the conditional execution of the 'Prepare bundled CLI for npm release' step, adding a check to ensure it does not run for releases tagged as latest. This change aligns with the goal of running the bundling process only for pre-releases.
Summary
This PR restricts the new NPM release bundling step to pre-releases (
preview,nightly, etc.) so that we can fully test the bundled CLI artifacts before applying this change to stable (latest) releases.Details
The GitHub Action
publish-releasenow explicitly excludeslatestfrom running theprepare-npm-release.jsbundling script. This ensureslatestdeployments remain unchanged for now.Related Issues
Closes #21820
How to Validate
scripts/prepare-npm-release.jsis not run during a stable release publish action.Pre-Merge Checklist