docs: clarify global policy rules application in plan mode#21864
Conversation
Clarify in docs/cli/plan-mode.md that policy rules without an explicit 'modes' setting apply to Plan Mode. Added a new section 'Global vs. mode-specific rules' with an example of how to exclude rules from Plan Mode by specifying other modes. See: docs/reference/policy-engine.md#approval-modes
|
Size Change: -4 B (0%) Total Size: 26.1 MB ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation for Plan Mode by clarifying how global policy rules are applied and providing an example of how to define mode-specific rules. This change helps users understand how to configure policies to behave differently in Plan Mode versus other modes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances the documentation for Plan Mode by adding a new section, 'Global vs. mode-specific rules'. This addition clarifies that policy rules lacking an explicit modes attribute are considered global and thus apply in Plan Mode. The change includes a practical example demonstrating how to configure a rule to apply to specific modes while excluding it from Plan Mode. The update is accurate and significantly improves the clarity of the policy engine's behavior for users. The changes have been reviewed and no issues were found.
Note: Security Review has been skipped due to the limited scope of the PR.
Clarify in docs/cli/plan-mode.md that policy rules without an explicit 'modes' setting apply to Plan Mode. Added a new section 'Global vs. mode-specific rules' with an example of how to exclude rules from Plan Mode by specifying other modes.
See: docs/reference/policy-engine.md#approval-modes
Closes #21709
Closes #21585