fix(core): update @a2a-js/sdk to 0.3.11#21875
Conversation
|
Hi @adamfweidman, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Hi there! Thank you for your contribution to Gemini CLI. To improve our contribution process and better track changes, we now require all pull requests to be associated with an existing issue, as announced in our recent discussion and as detailed in our CONTRIBUTING.md. This pull request is being closed because it is not currently linked to an issue. Once you have updated the description of this PR to link an issue (e.g., by adding How to link an issue: Thank you for your understanding and for being a part of our community! |
|
Thank you for linking an issue! This pull request has been automatically reopened. |
|
Size Change: +1.72 kB (+0.01%) Total Size: 26.1 MB
ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on maintaining the project's health and compatibility by upgrading a critical dependency. The update to Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the @a2a-js/sdk dependency to version 0.3.11 in both packages/core and packages/a2a-server. The changes are straightforward, but I've noticed that the updated dependencies are pinned to a specific version, which is inconsistent with other dependencies in the package.json files that use caret (^) ranges. I've left comments suggesting to use ^0.3.11 for consistency, which will improve maintainability.
Note: Security Review has been skipped due to the limited scope of the PR.
| ], | ||
| "dependencies": { | ||
| "@a2a-js/sdk": "^0.3.8", | ||
| "@a2a-js/sdk": "0.3.11", |
There was a problem hiding this comment.
To maintain consistency with other dependencies in this file, which use caret (^) version ranges (e.g., @google-cloud/storage), this dependency should also use a caret. This ensures a consistent dependency management strategy across the project.
| "@a2a-js/sdk": "0.3.11", | |
| "@a2a-js/sdk": "^0.3.11", |
| ], | ||
| "dependencies": { | ||
| "@a2a-js/sdk": "^0.3.10", | ||
| "@a2a-js/sdk": "0.3.11", |
There was a problem hiding this comment.
Summary
Update
@a2a-js/sdkto version0.3.11inpackages/coreandpackages/a2a-server.Details
This update ensures compatibility with the latest features and fixes in the
@a2a-js/sdk. During the update, thepackage-lock.jsonwas also cleaned of redundant"peer": trueentries by running a clean install with Node 22 (though.nvmrcwas not updated in this commit as per user request).Related Issues
#18199
How to Validate
npm installto ensure dependencies are correctly resolved.package-lock.json:grep -C 5 '"@a2a-js/sdk"' package-lock.jsonPre-Merge Checklist