docs: clarify telemetry setup and comprehensive data map#21879
Conversation
|
Size Change: -4 B (0%) Total Size: 26.2 MB ℹ️ View Unchanged
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Gemini CLI's observability documentation by restructuring the telemetry guide. The changes aim to provide a clearer, more concise understanding of how logs, metrics, and traces contribute to AI observability, simplifying the setup process for Google Cloud, and centralizing information for viewing telemetry data. This refactoring improves the user experience for developers seeking to debug and optimize agent behavior. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request significantly refactors the telemetry documentation to improve clarity and structure. The changes simplify the setup instructions for Google Cloud, move developer-specific collector information to the local development guide, and centralize instructions for viewing telemetry data.
While the refactoring is a great improvement, I've identified a couple of areas where important information was removed. One is a warning about a specific configuration conflict (useCliAuth and useCollector), and the other is the removal of detailed attribute lists for logs and metrics, which reduces the document's utility as a comprehensive data reference. My review includes suggestions to restore this information to ensure the documentation remains complete and accurate for users.
Note: Security Review has been skipped due to the limited scope of the PR.
3bc9a06 to
cf000da
Compare
Refactored the telemetry guide to focus on the value of logs, metrics, and traces as the foundation for AI observability. - Simplified Google Cloud setup with two authentication methods (ADC vs CLI Auth). - Moved developer-only collector scripts to the local development guide. - Added a centralized 'View Google Cloud telemetry' section with direct console links and official documentation. - Completed a comprehensive scan of the telemetry implementation to include all missing logs, metrics, and trace attributes. - Standardized headings, introductory paragraphs, and applied 80-character text wrapping.
cf000da to
1926815
Compare
Refactored the telemetry guide to focus on the value of logs, metrics, and traces as the foundation for AI observability.
Closes #21882
Preview: https://github.com/google-gemini/gemini-cli/blob/docs/clarify-telemetry/docs/cli/telemetry.md