Skip to content

make command names consistent#21907

Merged
scidomino merged 1 commit intomainfrom
tomm_key
Mar 10, 2026
Merged

make command names consistent#21907
scidomino merged 1 commit intomainfrom
tomm_key

Conversation

@scidomino
Copy link
Collaborator

@scidomino scidomino commented Mar 10, 2026

Summary

Make command names consistent so they look nice when users can use custom key bindings.

Related Issues

For #21294

How to Validate

Try background shell.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@scidomino scidomino marked this pull request as ready for review March 10, 2026 18:18
@scidomino scidomino requested review from a team as code owners March 10, 2026 18:18
@github-actions
Copy link

Size Change: -196 B (0%)

Total Size: 26.2 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 25.7 MB -196 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the consistency and organization of command names, particularly those related to background shell controls. The changes aim to provide a more intuitive experience for users who customize key bindings, by ensuring command names are logical and grouped appropriately. This involves internal code refactoring and updates to the keyboard shortcuts documentation.

Highlights

  • Command Naming Consistency: Refactored command names for background shell controls to follow a consistent naming convention, improving clarity and predictability for custom key bindings.
  • Background Shell Controls Grouping: Grouped all background shell-related commands into a dedicated category within the Command enum, default key bindings, command categories, and command descriptions.
  • Documentation Update: Updated the keyboard-shortcuts.md documentation to reflect the new grouping and organization of background shell controls, presenting them in a distinct section.
Changelog
  • docs/reference/keyboard-shortcuts.md
    • Reorganized the display of background shell controls into a distinct section.
  • packages/cli/src/ui/key/keyBindings.ts
    • Renamed Command enum members for background shell operations to follow a consistent background. pattern.
    • Reordered defaultKeyBindings to align with the new command categorization.
    • Updated the VALID_KEYS static property to use more compact array literal definitions for punctuation, function keys, and numpad keys.
    • Reorganized commandCategories and commandDescriptions to group background shell controls separately.
Activity
  • No human activity has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request significantly improves the consistency and organization of command names and their associated keybindings, especially for background shell controls. The changes to the Command enum, defaultKeyBindings, commandCategories, and commandDescriptions ensure a more logical structure and clearer naming convention (e.g., background.escape instead of backgroundShellEscape). The documentation in keyboard-shortcuts.md has also been updated to reflect these changes, making it easier for users to understand the available shortcuts. The consolidation of VALID_KEYS for punctuation, function keys, and numpad numbers also enhances code readability and maintainability.

@gemini-cli gemini-cli bot added priority/p1 Important and should be addressed in the near term. area/core Issues related to User Interface, OS Support, Core Functionality labels Mar 10, 2026
@scidomino scidomino added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit 077c1a1 Mar 10, 2026
30 of 31 checks passed
@scidomino scidomino deleted the tomm_key branch March 10, 2026 19:30
JaisalJain pushed a commit to JaisalJain/gemini-cli that referenced this pull request Mar 11, 2026
kunal-10-cloud pushed a commit to kunal-10-cloud/gemini-cli that referenced this pull request Mar 12, 2026
liamhelmer pushed a commit to badal-io/gemini-cli that referenced this pull request Mar 12, 2026
yashodipmore pushed a commit to yashodipmore/geemi-cli that referenced this pull request Mar 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/core Issues related to User Interface, OS Support, Core Functionality priority/p1 Important and should be addressed in the near term.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants